fixup: remove legacy format from modal, add test for change export format and default

Author: Anemy

packages/compass-schema/src/components/export-schema-modal.tsx

@@ -1,7 +1,6 @@
 import React, { type ChangeEvent, useCallback } from 'react';
 import { connect } from 'react-redux';
 import {
-  Banner,
   Button,
   Code,
   ModalBody,
@@ -30,10 +29,6 @@ const loaderStyles = css({
   marginTop: spacing[400],
 });
 
-const legacyWarningStyles = css({
-  marginTop: spacing[200],
-});
-
 const contentContainerStyles = css({
   paddingTop: spacing[400],
   paddingBottom: spacing[400],
@@ -135,20 +130,6 @@ const ExportSchemaModal: React.FunctionComponent<{
             );
           })}
         </RadioBoxGroup>
-        {exportFormat === 'legacyJSON' && (
-          <Banner
-            className={legacyWarningStyles}
-            variant="warning"
-            data-testid="legacy-export-json-warning"
-          >
-            <strong>
-              The JSON Extended format is deprecated and will be removed in a
-              future release.
-            </strong>
-            &nbsp;We&apos;re transitioning to a better format. Discover the new
-            experience by selecting a relevant format from above.
-          </Banner>
-        )}
         <div className={contentContainerStyles}>
           {exportStatus === 'inprogress' && (
             <CancelLoader

packages/compass-schema/src/modules/schema-analysis.spec.ts

@@ -160,7 +160,10 @@ describe('schema-analysis', function () {
         count: 2,
       };
 
-      const internalSchema = await schema!.getInternalSchema();
+      if (!schema) {
+        throw new Error('schema is nul');
+      }
+      const internalSchema = await schema.getInternalSchema();
       internalSchema.fields = internalSchema.fields.filter(
         ({ path }) => !isInternalFieldPath(path[0])
       );

packages/compass-schema/src/stores/store.spec.ts

@@ -2,6 +2,7 @@ import { activateSchemaPlugin } from './store';
 import type { SchemaStore, SchemaPluginServices } from './store';
 import AppRegistry, { createActivateHelpers } from 'hadron-app-registry';
 import { expect } from 'chai';
+import { waitFor } from '@mongodb-js/testing-library-compass';
 
 import { ANALYSIS_STATE_INITIAL } from '../constants/analysis-states';
 import { createSandboxFromDefaultPreferences } from 'compass-preferences-model';
@@ -10,7 +11,10 @@ import type { FieldStoreService } from '@mongodb-js/compass-field-store';
 import { createNoopTrack } from '@mongodb-js/compass-telemetry/provider';
 import { startAnalysis, stopAnalysis } from './schema-analysis-reducer';
 import Sinon from 'sinon';
-import { changeExportSchemaFormat } from './schema-export-reducer';
+import {
+  changeExportSchemaFormat,
+  openExportSchema,
+} from './schema-export-reducer';
 
 const dummyLogger = createNoopLogger('TEST');
 const dummyTrack = createNoopTrack();
@@ -135,10 +139,18 @@ describe('Schema Store', function () {
           await store.dispatch(startAnalysis());
         });
 
-        it('runs schema export formatting with the analyzed schema', async function () {
+        it('runs schema export formatting with the analyzed schema when opened', async function () {
           sampleStub.resolves([{ name: 'Hans' }, { name: 'Greta' }]);
-          await store.dispatch(changeExportSchemaFormat('standardJSON'));
           expect(sampleStub).to.have.been.called;
+          expect(store.getState().schemaExport.exportStatus).to.equal(
+            'inprogress'
+          );
+          store.dispatch(openExportSchema());
+          await waitFor(() => {
+            expect(store.getState().schemaExport.exportStatus).to.equal(
+              'complete'
+            );
+          });
           const { exportStatus, errorMessage, exportedSchema } =
             store.getState().schemaExport;
           expect(exportStatus).to.equal('complete');
@@ -153,6 +165,24 @@ describe('Schema Store', function () {
             name: { type: 'string' },
           });
         });
+
+        it('runs schema export formatting with a new format', async function () {
+          sampleStub.resolves([{ name: 'Hans' }, { name: 'Greta' }]);
+          await store.dispatch(changeExportSchemaFormat('mongoDBJSON'));
+          expect(sampleStub).to.have.been.called;
+          const { exportStatus, errorMessage, exportedSchema } =
+            store.getState().schemaExport;
+          expect(exportStatus).to.equal('complete');
+          expect(!!errorMessage).to.be.false;
+          expect(exportedSchema).not.to.be.undefined;
+          expect(JSON.parse(exportedSchema!).type).to.equal(undefined);
+          expect(JSON.parse(exportedSchema!).bsonType).to.equal('object');
+          expect(JSON.parse(exportedSchema!)['$schema']).to.equal(undefined);
+          expect(JSON.parse(exportedSchema!).required).to.deep.equal(['name']);
+          expect(JSON.parse(exportedSchema!).properties).to.deep.equal({
+            name: { bsonType: 'string' },
+          });
+        });
       });
     });