feat(connection-form): show a banner on the connection form explaining why you can't edit the connection COMPASS-8264 #6344
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
lerouxb
commented
Oct 10, 2024
lerouxb
commented
lerouxb
changed the title
gribnoysup
approved these changes
Oct 10, 2024
| </div> | ||
| </Banner> | ||
| )} | ||
| {protectConnectionStrings && ( |
Collaborator
There was a problem hiding this comment.
I know it's a corner case, but would it make more sense to make this banner show up only when you can actually edit the connection string taking connection status into account? Otherwise it's getting pretty packed in there when editing a connected one:
Contributor
Author
There was a problem hiding this comment.
Aah well spotted. Fixed.
paula-stacho
approved these changes
Oct 10, 2024
Collaborator
paula-stacho
left a comment
paula-stacho
left a comment
There was a problem hiding this comment.
I'd go for .is.visible instead of .to.exist for better safety, but it's not a blocker
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.