chore(compass-schema): "Schema Exported" event COMPASS-8332 #6389
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kraenhansen
changed the title
kraenhansen
force-pushed
the
kh/schema-shared-event
branch
from
15fbd21 to
b26708a
Compare
Anemy
approved these changes
Oct 22, 2024
Member
Anemy
left a comment
Anemy
left a comment
There was a problem hiding this comment.
lgtm, one suggestion on reducing some code duplication, not a blocker.
kraenhansen
force-pushed
the
kh/schema-shared-event
branch
from
b26708a to
55bdb82
Compare
kraenhansen
changed the title
Anemy
approved these changes
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a "Schema Exported" telemetry-event firing when clicking the "Share Schema as JSON" menu item:
I've verified the implementation running
and
Checklist
Motivation and Context
Open Questions
Dependents
Types of changes