Skip to content

Conversation

@paula-stacho
Copy link
Collaborator

@paula-stacho paula-stacho commented Oct 25, 2024

Description

When the collection has already been geosharded with one key, it cannot be sharded with another one. Until now, we allowed this because we went from SHARD_KEY_CORRECT -> UNSHARDED. This PR handles the state when collection has already been sharded (shardKey exists), but it is not managed now. The new state is INCOMPLETE_SHARDING_SETUP, and from this state we can only resume sharding. The request is the same, but the key description is taken from the existing key, not user input.

The change looks bigger than it is - example-commands-markup.tsx and shard-zones-description.tsx are just moved out of shard-key-correct.tsx. The bulk of changes is in the reducer, which had to be rearranged a bit to incorporate the new scenario (we haven't realised this possibility exists until later on).

Screenshot 2024-10-31 at 13 13 03

Checklist

Motivation and Context

  • Bugfix
  • New feature
  • Dependency update
  • Misc

Open Questions

Dependents

Types of changes

  • Backport Needed
  • Patch (non-breaking change which fixes an issue)
  • Minor (non-breaking change which adds functionality)
  • Major (fix or feature that would cause existing functionality to change)

@github-actions github-actions bot added the feat label Oct 25, 2024
@paula-stacho paula-stacho added the no release notes Fix or feature not for release notes label Oct 31, 2024
@paula-stacho paula-stacho marked this pull request as ready for review October 31, 2024 12:51
@paula-stacho paula-stacho merged commit 29ee428 into main Nov 6, 2024
30 checks passed
@paula-stacho paula-stacho deleted the COMPASS-8372 branch November 6, 2024 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feat no release notes Fix or feature not for release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants