feat(global-writes): open global writes tab when creating a collection COMPASS-8280 #6405
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| workspaces.openCollectionWorkspace(connectionId, namespace, { | ||
| newTab: true, | ||
| initialSubtab: | ||
| connectionInfo && connectionSupports(connectionInfo, 'globalWrites') |
Collaborator
There was a problem hiding this comment.
connectionSupports won't be sufficient. we'll need to filter out the admin/config/local collections and also views. adding @djechlin-mongodb, we'll need to sync this with the hiding of the tab
more context: https://mongodb.slack.com/archives/C03DU5ATTB6/p1729869659313749
Collaborator
There was a problem hiding this comment.
sorry for only realising this now 🙈
Collaborator
There was a problem hiding this comment.
You can't create views through this modal and I'm pretty sure that even db users with admin roles can't create collections inside special-ish namespaces (but for anything that is defined as special-ish by mongodb-ns package we probably can add a filter here, yeah)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checklist
Motivation and Context
Open Questions
Dependents
Types of changes