chore(connections-navigation): disable sidebar right-caret on disconnected connections #6499
Conversation
kraenhansen
added
no release notes
kraenhansen
changed the title
| <ExpandButton | ||
| onClick={(evt) => { | ||
| if (isExpandDisabled) return; | ||
| evt.stopPropagation(); |
There was a problem hiding this comment.
I think this is still desirable because what I noticed - once you connect, and click on the expanded caret to collapse the tree, the default action (to open the tab for databases list) happens instead of collapse.
There was a problem hiding this comment.
I was hoping you'd share context on this. I forgot to ask directly 😬
I'll add it back and write a comment on why it's there 👍
| toggleExpand(); | ||
| }} | ||
| isExpanded={isExpanded} | ||
| disabled={isExpandDisabled} |
There was a problem hiding this comment.
Based on what Betsy's message, I was under the impression we were going to hide the caret altogether, not make it disabled: https://mongodb.slack.com/archives/G2L10JAV7/p1731623253437699?thread_ts=1731413469.751959&cid=G2L10JAV7
I feel showing it in the UI makes me want to click it. I feel we should either make it not show up at all or make it clickable to connect.
There was a problem hiding this comment.
@bsradcliffe wanted to keep them (see #6449 (comment))
I would like to preserve the chevrons.
There was a problem hiding this comment.
Cool cool, fine as is then. I'll ping @bsradcliffe to see if making them clickable to connect is an option, or if we want to keep it as is with the disabled.
Description
This is a follow-up to #6449.
Merging this PR will:
Checklist
Motivation and Context
Open Questions
Dependents
Types of changes