Skip to content

fix(compass-components): don't cut off list view value editor tooltips COMPASS-8581 #6541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 4, 2024
Merged

fix(compass-components): don't cut off list view value editor tooltips COMPASS-8581 #6541

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
18d16ff
don't turn off the portal
lerouxb Nov 29, 2024
30ad4ad
Merge branch 'main' into fix-tooltip-nesting
lerouxb Nov 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions packages/compass-components/src/components/document-list/element-editors.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,6 @@ export const KeyEditor: React.FunctionComponent<{
<Tooltip
darkMode
enabled={!valid}
usePortal={false}
trigger={({
className,
// Having a tooltip connected to the input elements is not the most
Expand Down Expand Up @@ -223,7 +222,6 @@ export const ValueEditor: React.FunctionComponent<{
<Tooltip
darkMode
enabled={!valid}
usePortal={false}
trigger={({
className,
children,
Expand Down
Loading