Skip to content

fix(connections-navigation): don't show connect button while connecting COMPASS-8599 #6550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 5, 2024
Merged

fix(connections-navigation): don't show connect button while connecting COMPASS-8599 #6550

merged 1 commit into from
Dec 5, 2024

Conversation

@kraenhansen
Copy link
Contributor

@kraenhansen kraenhansen commented Dec 5, 2024 •
edited
Loading

Description

Merging this PR will:

  • Remove the "Connect" action / button from a connection row in the sidebar, while a connection is being established.

This is a follow-up to #6449.

Screen.Recording.2024-12-05.at.09.23.58.mov

Checklist

Motivation and Context

  • Bugfix
  • New feature
  • Dependency update
  • Misc

Open Questions

Dependents

Types of changes

  • Backport Needed
  • Patch (non-breaking change which fixes an issue)
  • Minor (non-breaking change which adds functionality)
  • Major (fix or feature that would cause existing functionality to change)

@kraenhansen kraenhansen self-assigned this Dec 5, 2024
@github-actions github-actions bot added the fix label Dec 5, 2024
@kraenhansen kraenhansen requested a review from lerouxb December 5, 2024 08:34
@lerouxb lerouxb added the no release notes Fix or feature not for release notes label Dec 5, 2024
@kraenhansen kraenhansen merged commit 1e21358 into main Dec 5, 2024
31 of 33 checks passed
@kraenhansen kraenhansen deleted the kh/avoid-connect-action-when-connecting branch December 5, 2024 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lerouxb lerouxb lerouxb approved these changes

Assignees

@kraenhansen kraenhansen

Labels

fix no release notes Fix or feature not for release notes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kraenhansen @lerouxb