Skip to content

Conversation

@mabaasit
Copy link
Collaborator

@mabaasit mabaasit commented Jan 9, 2025

With this prop, we will be able to handle showing custom error page instead of a toast on mms side.

Description

Checklist

Motivation and Context

  • Bugfix
  • New feature
  • Dependency update
  • Misc

Open Questions

Dependents

Types of changes

  • Backport Needed
  • Patch (non-breaking change which fixes an issue)
  • Minor (non-breaking change which adds functionality)
  • Major (fix or feature that would cause existing functionality to change)

@github-actions github-actions bot added the feat label Jan 9, 2025
@paula-stacho
Copy link
Collaborator

The description says "instead of a toast", but I don't see removing the old toast - did we have no error handling before?

@mabaasit
Copy link
Collaborator Author

mabaasit commented Jan 9, 2025

we have no error handling before

We did have error handling before, but we did not show any toast (because we never fail to load compass connections). So i added that, to show the toast for CompassDesktop). And for CompassWeb, will let mms handle it.

Copy link
Collaborator

@paula-stacho paula-stacho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd suggest adding a test or two, but otherwise looks good!

@mabaasit mabaasit merged commit e61c9c3 into main Jan 9, 2025
33 of 34 checks passed
@mabaasit mabaasit deleted the COMPASS-8657-error branch January 9, 2025 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants