chore(web): align cluster connection options with the design COMPASS-8794 #6603
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
syn-zhu
approved these changes
Jan 10, 2025
gribnoysup
commented
Jan 10, 2025
| class Socket extends Duplex { | ||
| private _tls = false; | ||
| private _ws: WebSocket | null = null; | ||
| private _setOptions: { |
Collaborator
Author
There was a problem hiding this comment.
Drive-by clean-up, this was doing nothing after a recent change to the logic of the proxy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was debugging a flaky test and tracked it down to CCS currently not supporting streaming monitoring (known limitation for now), we already decided to disable it for now (see tech design) opting into the polling monitoring, but never updated compass-web to account for that. This patch aligns this and other options with the tech design, polling being the most important to fix as this causes real issues at the moment