chore(e2e): few suggestions to smoke-test.ts #6607
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kraenhansen
added
the
no-title-validation
kraenhansen
force-pushed
the
kh/smoke-test/refactor-platform-and-archs
branch
from
26e04ff to
ccf4d5d
Compare
kraenhansen
commented
Jan 13, 2025
| const parsedArgs = argv.parseSync(); | ||
|
|
||
| const context = parsedArgs as SmokeTestsContext; | ||
| const context: SmokeTestsContext = argv.parseSync(); |
Contributor
Author
There was a problem hiding this comment.
Ideally I would have either used satisfies here (but our prettier's typescript parser needs an update to support that) or simply deleted the type now that it matches the expected type.
Suggested change
| const context: SmokeTestsContext = argv.parseSync(); | |
| const context = argv.parseSync() satisfies SmokeTestsContext; |
lerouxb
approved these changes
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Unfortunately default values by-pass yarg's validation: Here's a few suggestions to avoid a type assert and potential runtime issue if
ARCHorPLATFORMenvironment variables doesn't match the supported values.Checklist
Motivation and Context
Open Questions
Dependents
Types of changes