feat(compass): show the autoupdate installed toast even when we downgrade COMPASS-8808 #6612
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lerouxb
commented
Jan 14, 2025
| if ( | ||
| semver.gt(APP_VERSION, state.previousVersion) && | ||
| state.previousVersion !== DEFAULT_APP_VERSION | ||
| state.previousVersion !== DEFAULT_APP_VERSION && |
Contributor
Author
There was a problem hiding this comment.
Same justification and discussion as https://github.com/mongodb-js/compass/pull/6608/files#r1913799566
lerouxb
commented
Jan 14, 2025
| <button | ||
| className={cx(buttonStyles, darkmode && buttonDarkStyles)} | ||
| onClick={onUpdateClicked} | ||
| data-testid="auto-update-restart-button" |
Contributor
Author
There was a problem hiding this comment.
As a drive-by I'm adding these test ids so the latest nightly dev release will end up with them and then the auto-update tests can use them.
gribnoysup
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also adds logging that will be super helpful in debugging auto-update. Especially during testing. And some data-testids we can use in the tests to address things in the relevant toasts.