Skip to content

feat(compass): show the autoupdate installed toast even when we downgrade COMPASS-8808 #6612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 14, 2025
Merged

feat(compass): show the autoupdate installed toast even when we downgrade COMPASS-8808 #6612

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
78cc0c9
Show the autoupdate installed toast even when we downgrade
lerouxb Jan 14, 2025
c91a221
add data-testids to the toasts needed for testing
lerouxb Jan 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions packages/compass/src/app/components/update-toasts.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,7 @@ const RestartCompassToastContent = ({
<button
className={cx(buttonStyles, darkmode && buttonDarkStyles)}
onClick={onUpdateClicked}
data-testid="auto-update-restart-button"
Copy link
Contributor Author

@lerouxb lerouxb Jan 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a drive-by I'm adding these test ids so the latest nightly dev release will end up with them and then the auto-update tests can use them.

>
Restart
</button>
Expand Down Expand Up @@ -83,6 +84,7 @@ export function onAutoupdateExternally({
Compass features.
</Body>
<Link
data-testid="auto-update-download-link"
as="a"
target="_blank"
href={'https://www.mongodb.com/try/download/compass'}
Expand Down Expand Up @@ -137,6 +139,7 @@ export function onAutoupdateInstalled({ newVersion }: { newVersion: string }) {
title: `Compass ${newVersion} installed successfully`,
description: (
<Link
data-testid="auto-update-release-notes-link"
as="a"
target="_blank"
href={`https://github.com/mongodb-js/compass/releases/tag/v${newVersion}`}
Expand Down
10 changes: 8 additions & 2 deletions packages/compass/src/app/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -379,9 +379,15 @@ const app = {
});
}

log.info(mongoLogId(1_001_000_338), 'Main Window', 'Recent version info', {
previousVersion: state.previousVersion,
highestInstalledVersion: state.highestInstalledVersion,
APP_VERSION,
});

if (
semver.gt(APP_VERSION, state.previousVersion) &&
state.previousVersion !== DEFAULT_APP_VERSION
state.previousVersion !== DEFAULT_APP_VERSION &&
Copy link
Contributor Author

@lerouxb lerouxb Jan 14, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same justification and discussion as https://github.com/mongodb-js/compass/pull/6608/files#r1913799566

APP_VERSION !== state.previousVersion
) {
// Wait a bit before showing the update toast.
setTimeout(() => {
Expand Down
Loading