fix(e2e): do not pass version to hadron build info - have it figure it out on its own COMPASS-8812 #6613
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lerouxb
added
no release notes
lerouxb
changed the title
lerouxb
commented
Jan 14, 2025
…test) all the logic in target.js
lerouxb
changed the title
gribnoysup
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Evergreen sets DEV_VERSION_IDENTIFIER to an empty string for beta/ga builds and we don't want to pass that to hadron build info because it will use
''and then throw an error when it tries to parse it with semver. Furthermore target.js (used by hadron build info) already uses all sorts of env vars and has all sorts of fallbacks and logic that end up just interfering with what we try and set as a parameter, so rather than try and second-guess that let's rather leave it up to hadron build info to do all that.see https://spruce.mongodb.com/task/10gen_compass_testing_smoketest_ubuntu_compass_smoketest_compass_8c8e61ee1d97ed7e5d8b9cef01553c57a968bdab_25_01_13_05_05_18/logs?execution=1
This also logs the relevant env vars that target.js might be using as a reminder to us that things are happening behind the scenes.