fix(atlas-service): dont signin twice in tests COMPASS-8837 #6624
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mabaasit
commented
Jan 16, 2025
Comment on lines
-179
to
-182
| await Promise.all([ | ||
| store.dispatch(signIn()), | ||
| store.dispatch(cancelSignIn()), | ||
| ]); |
Collaborator
Author
There was a problem hiding this comment.
We are already attempting signin in performSignInAttempt and doing it here, triggers isAuthenticated stub and hence rejecting the promise after the test has finished with its assertions.
So I removed extra signin and also ensured that isAuthenticated is only called once.
gribnoysup
approved these changes
Jan 16, 2025
mabaasit
changed the title
mabaasit
force-pushed
the
atlas-sign-in-flake
branch
from
1a78d04 to
95d1937
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CI run: https://parsley.mongodb.com/evergreen/10gen_compass_main_unit_tests_macos_test_patch_ea4869a6b73c34752a4ca8e4effe5d4010aab19d_6788d4bd495020000767142d_25_01_16_09_43_26/0/task?bookmarks=0,7306&shareLine=7183
Description
Checklist
Motivation and Context
Open Questions
Dependents
Types of changes