chore(smoke-tests): move files into its own package #6625
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kraenhansen
commented
Jan 16, 2025
Comment on lines
-6
to
-8
|
|
||
| // Hacking types here because the DOM types doesn't match the fetch implemented by Node.js | ||
| const fetch = globalThis.fetch as unknown as typeof undiciFetch; |
Contributor
Author
There was a problem hiding this comment.
Now that the TS project has lib locked down, we no longer need this.
addaleax
approved these changes
Jan 16, 2025
lerouxb
reviewed
Jan 16, 2025
.evergreen/functions.yml
Outdated
| # separately in the test-packaged-app task | ||
| export IGNORE_TESTS="compass-e2e-tests" | ||
| # Some packages are ignored as we are running these separately | ||
| export IGNORE_TESTS="(compass-e2e-tests|compass-smoke-tests)" |
Contributor
There was a problem hiding this comment.
As long as there isn't a test-ci in the package.json we don't need this, but I suppose it is harmless.
Contributor
Author
There was a problem hiding this comment.
Good catch. I'll revert this to avoid potential confusion and keep things simple 👍
lerouxb
approved these changes
Jan 16, 2025
kraenhansen
added
the
no-title-validation
kraenhansen
force-pushed
the
kh/smoke-test/own-package
branch
from
93a12c0 to
8db3470
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Merging this PR will move smoke-test related files into its own package.
Checklist
Motivation and Context
Open Questions
Dependents
Types of changes