chore(web): catch and log errors when building connection info instead of throwing COMPASS-8848 #6635
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
addaleax
approved these changes
Jan 20, 2025
| deployment: Deployment, | ||
| extraConnectionOptions?: Record<string, any> | ||
| ) { | ||
| ): ConnectionInfo { |
Co-authored-by: Anna Henningsen <[email protected]>
addaleax
approved these changes
Jan 20, 2025
lerouxb
approved these changes
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For initial launch we want to make the cluster fetching less strict to make sure that the whole compass-web feature doesn't get disabled if some of the clusters end up in the state we didn't anticipate. This patch changes the connection storage in compass-web to filter out clusters when we were not able to build required metadata for connection to be usable in compass and log errors in case anything unexpected happened.