chore(preferences): remove multiple connections feature flag COMPASS-7906 #6636
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lerouxb
approved these changes
Jan 21, 2025
Contributor
lerouxb
left a comment
lerouxb
left a comment
There was a problem hiding this comment.
So glad that I wasn't the one that had to hunt all this stuff down 😆
Collaborator
Author
|
Merged main to get another CI run and check that I didn't add any flakes with this change |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the feature flag and some branching logic that was still around. I don't think there is anything of note that got changed in this PR, so not highlighting anything in particular. Sidebar can still probably do with some cleanup, the way multiple connections was initially implemented left the store there in a weird state, but we do have a separate ticket for that.
A decent amount of code changed the nesting level without further changes, so I recommend reviewing with whitespace diff turned off.