feat(smoke-tests): test zip installer for on Windows COMPASS-8710 #6637
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kraenhansen
force-pushed
the
kh/smoke-test/zip-installers
branch
from
2521181 to
7d3349b
Compare
lerouxb
reviewed
Jan 21, 2025
| ], | ||
| { | ||
| // We need to use a shell to get environment variables setup correctly | ||
| shell: true, |
Contributor
There was a problem hiding this comment.
👍
(I think I noticed the same in an open PR)
lerouxb
reviewed
Jan 21, 2025
| kind, | ||
| buildInfo, | ||
| filename: buildInfo[`${kind}_filename`], | ||
| appName: buildInfo.installerOptions.name, |
Contributor
There was a problem hiding this comment.
Do you have examples of how these differ from productName? Just curious.
Contributor
Author
There was a problem hiding this comment.
It needed to be MongoDBCompassDev on windows (no spaces).
lerouxb
approved these changes
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Merging this PR will:
appNamepassed when running the e2e tests from the build file (field name is TBD for Linux)Checklist
Motivation and Context
Open Questions
Dependents
Types of changes