Skip to content

Conversation

@paula-stacho
Copy link
Collaborator

@paula-stacho paula-stacho commented Feb 6, 2025

Description

The second parameter is scope, but code with scope has been deprecated (see bson spec). BSON supports optional scope still, but it becomes a problem if we add validation (this is how I stumbled upon it), because this becomes the deprecated bson type.

Before:
Screenshot 2025-02-06 at 14 09 50

After:
Screenshot 2025-02-06 at 14 09 39

Checklist

Motivation and Context

  • Bugfix
  • New feature
  • Dependency update
  • Misc

Open Questions

Dependents

Types of changes

  • Backport Needed
  • Patch (non-breaking change which fixes an issue)
  • Minor (non-breaking change which adds functionality)
  • Major (fix or feature that would cause existing functionality to change)

@github-actions github-actions bot added the fix label Feb 6, 2025
@paula-stacho paula-stacho changed the title fix(hadron-type-checker): remove legacy scope from code COMPASS-8921 fix(hadron-type-checker): remove deprecated scope from code COMPASS-8921 Feb 6, 2025
@github-actions github-actions bot added the fix label Feb 6, 2025
@paula-stacho paula-stacho added no release notes Fix or feature not for release notes and removed release notes fix labels Feb 6, 2025
@github-actions github-actions bot added the fix label Feb 6, 2025
@paula-stacho paula-stacho marked this pull request as ready for review February 6, 2025 13:51
@paula-stacho paula-stacho merged commit e8a3866 into main Feb 6, 2025
42 of 47 checks passed
@paula-stacho paula-stacho deleted the COMPASS-8921 branch February 6, 2025 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fix no release notes Fix or feature not for release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants