Skip to content

Conversation

@kraenhansen
Copy link
Contributor

Description

Merging this PR will:

  1. Implement the Linux .tar installer (using the tar command and verifying compass --version via xvfb-run).
  2. Arm CI with the Ubuntu build variant to execute the smoke tests for the Ubuntu tar installer (only running time-to-first-query for now).

Checklist

Motivation and Context

  • Bugfix
  • New feature
  • Dependency update
  • Misc

Open Questions

Dependents

Types of changes

  • Backport Needed
  • Patch (non-breaking change which fixes an issue)
  • Minor (non-breaking change which adds functionality)
  • Major (fix or feature that would cause existing functionality to change)

@kraenhansen kraenhansen changed the title Kh/smoke test/linux tar installer feat(smoke-tests): test tar installer for on Ubuntu COMPASS-8711 Feb 7, 2025
@kraenhansen kraenhansen force-pushed the kh/smoke-test/linux-tar-installer branch from da9fa7a to 05410a7 Compare February 7, 2025 11:28
@github-actions github-actions bot added the feat label Feb 7, 2025
@kraenhansen kraenhansen added the no release notes Fix or feature not for release notes label Feb 7, 2025
@kraenhansen kraenhansen self-assigned this Feb 7, 2025
@kraenhansen kraenhansen requested a review from lerouxb February 7, 2025 11:31
#if [[ "$IS_UBUNTU" == "true" ]]; then
# TODO: linux_deb
# TODO: linux_tar
npm run --unsafe-perm --workspace @mongodb-js/compass-smoke-tests start -- --package=linux_tar --tests=time-to-first-query
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this case it should be safe to run autoupdate-from because it won't auto-update, but it will tell the user that there is an update. And there's test code for that.

But we can also enable that in a separate PR.

@kraenhansen kraenhansen force-pushed the kh/smoke-test/linux-tar-installer branch from 05410a7 to a86cfe9 Compare February 7, 2025 20:24
@kraenhansen kraenhansen force-pushed the kh/smoke-test/linux-tar-installer branch from a223f25 to 026ae50 Compare February 10, 2025 08:44
@kraenhansen kraenhansen merged commit 5e68065 into main Feb 10, 2025
34 checks passed
@kraenhansen kraenhansen deleted the kh/smoke-test/linux-tar-installer branch February 10, 2025 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feat no release notes Fix or feature not for release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants