-
Notifications
You must be signed in to change notification settings - Fork 245
feat: legacy to new schema export COMPASS-8798 #6713
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
29e79a9 to
4572725
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, left a couple small questions/suggestions. It will be nice when we can get rid of this flow entirely down the line.
packages/compass-schema/src/components/export-schema-legacy-banner.tsx
Outdated
Show resolved
Hide resolved
| }; | ||
| }; | ||
|
|
||
| export const confirmedLegacySchemaShare = (): SchemaThunkAction<void> => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Calling out that in a branch I'm working on I've updated all the share wording to be export for the internals, so we have some more consistency. In case someone brings it up.
packages/compass-schema/src/components/export-schema-legacy-banner.tsx
Outdated
Show resolved
Hide resolved
…nner.tsx Co-authored-by: Rhys <[email protected]>
Co-authored-by: Rhys <[email protected]>
Description
This is a temporary modal for gentle sunsetting of the legacy schema export. With this in mind, I wanted to not spend too much time on it, so the code might not be the cream of the crop.
Notes:
Telemetry will be handled separately.
The tooltips and the background image are nice to have's, I will create a separate ticket for them.
Checklist
Motivation and Context
Open Questions
Dependents
Types of changes