Skip to content

Conversation

@paula-stacho
Copy link
Collaborator

@paula-stacho paula-stacho commented Feb 12, 2025

Description

This is a temporary modal for gentle sunsetting of the legacy schema export. With this in mind, I wanted to not spend too much time on it, so the code might not be the cream of the crop.
Notes:

  • the modal is behind the feature flag, to be released together with the new export
  • user can choose the legacy or the new behaviour
  • the modal shows every time they use the menu item, but there is a checkbox to turn it off

Telemetry will be handled separately.

The tooltips and the background image are nice to have's, I will create a separate ticket for them.

  • add tests

Checklist

Motivation and Context

  • Bugfix
  • New feature
  • Dependency update
  • Misc

Open Questions

Dependents

Types of changes

  • Backport Needed
  • Patch (non-breaking change which fixes an issue)
  • Minor (non-breaking change which adds functionality)
  • Major (fix or feature that would cause existing functionality to change)

@github-actions github-actions bot added the feat label Feb 12, 2025
@paula-stacho paula-stacho added the no release notes Fix or feature not for release notes label Feb 12, 2025
@paula-stacho paula-stacho marked this pull request as ready for review February 12, 2025 15:29
Copy link
Member

@Anemy Anemy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, left a couple small questions/suggestions. It will be nice when we can get rid of this flow entirely down the line.

};
};

export const confirmedLegacySchemaShare = (): SchemaThunkAction<void> => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Calling out that in a branch I'm working on I've updated all the share wording to be export for the internals, so we have some more consistency. In case someone brings it up.

@paula-stacho paula-stacho merged commit d0bb22b into main Feb 13, 2025
35 checks passed
@paula-stacho paula-stacho deleted the COMPASS-8798-2 branch February 13, 2025 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feat no release notes Fix or feature not for release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants