chore(smoke-tests): Refactor installers to take buildInfo directly
#6714
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kraenhansen
added
no release notes
kraenhansen
force-pushed
the
kh/smoke-test/refactor-installers
branch
2 times, most recently
from
36e2c97 to
01f092d
Compare
kraenhansen
force-pushed
the
kh/smoke-test/refactor-installers
branch
from
01f092d to
32ae4a6
Compare
lerouxb
approved these changes
Feb 12, 2025
Contributor
Author
|
Merging as the failure is unrelated to the changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Merging this PR will:
buildInfoand return theappNameinstead of taking theappNamedirectly.The main motivation for this, is computing the volume name when mounting the .dmg on Mac is more complicated than initially anticipated.
Checklist
Motivation and Context
Open Questions
Dependents
Types of changes