Skip to content

Conversation

@kraenhansen
Copy link
Contributor

Description

Since the GHA runners are pristine environments and we run only one package and test per job, the uninstalling and cleanup serve no purpose and is just adding noise.

Checklist

Motivation and Context

  • Bugfix
  • New feature
  • Dependency update
  • Misc

Open Questions

Dependents

Types of changes

  • Backport Needed
  • Patch (non-breaking change which fixes an issue)
  • Minor (non-breaking change which adds functionality)
  • Major (fix or feature that would cause existing functionality to change)

@kraenhansen kraenhansen added no release notes Fix or feature not for release notes no-title-validation Skips validation of PR titles (conventional commit adherence + JIRA ticket inclusion) labels Feb 14, 2025
@kraenhansen kraenhansen requested a review from lerouxb February 14, 2025 21:58
@kraenhansen kraenhansen self-assigned this Feb 14, 2025
@kraenhansen kraenhansen changed the title chore(smoke): skip uninstalling when running on GHA chore(smoke-tests): skip uninstalling when running on GHA Feb 14, 2025
@kraenhansen kraenhansen merged commit b940193 into main Feb 17, 2025
41 checks passed
@kraenhansen kraenhansen deleted the kh/smoke-test/skip-uninstall-on-gha branch February 17, 2025 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no release notes Fix or feature not for release notes no-title-validation Skips validation of PR titles (conventional commit adherence + JIRA ticket inclusion)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants