fix(compass-schema): complexity and size limits COMPASS-8905 COMPASS-8984 COMPASS-8941 #6733
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paula-stacho
force-pushed
the
COMPASS-8905
branch
from
7f3dff6 to
8b28447
Compare
paula-stacho
changed the title
Anemy
approved these changes
Feb 21, 2025
Member
Anemy
left a comment
Anemy
left a comment
There was a problem hiding this comment.
lgtm! One suggestion on using a shared variable, also a question on the 1000 number.
packages/compass-schema/src/components/schema-toolbar/schema-toolbar.tsx
Outdated
Show resolved
Hide resolved
Anemy
approved these changes
Feb 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The new limits are behind the export schema feature toggle. The messaging is similar to the bloated documents insights, the link leads to: www.mongodb.com/docs/manual/data-modeling/design-antipatterns/bloated-documents
Side changes: Error is no longer a separate state, we still show the 'Explore your schema' content. Errors can be dismissed.
Note: You can find bloated documents in Compass Data Sets ->
Schema Advisororvalidationsdb, or MDE Test ->bloated_documentsdb.Checklist
Motivation and Context
Open Questions
Dependents
Types of changes