Skip to content

Conversation

@paula-stacho
Copy link
Collaborator

@paula-stacho paula-stacho commented Feb 20, 2025

Description

I noticed that we have a mechanism for closing tab with unsaved changes - I figure the validation editor could benefit from it.

Checklist

Motivation and Context

  • Bugfix
  • New feature
  • Dependency update
  • Misc

Open Questions

Dependents

Types of changes

  • Backport Needed
  • Patch (non-breaking change which fixes an issue)
  • Minor (non-breaking change which adds functionality)
  • Major (fix or feature that would cause existing functionality to change)

@github-actions github-actions bot added the fix label Feb 20, 2025
@paula-stacho paula-stacho marked this pull request as ready for review February 20, 2025 10:40
@lerouxb
Copy link
Contributor

lerouxb commented Feb 20, 2025

The PR title goes in the release notes, so maybe it should make it clear that this helps prevent the user losing their changes? I interpreted it inverted the first time I read it.

@paula-stacho paula-stacho changed the title fix(compass-schema-validation): unsaved changes when closing tab COMPASS-9003 fix(compass-schema-validation): prevent losing changes in validation editor COMPASS-9003 Feb 20, 2025
@paula-stacho paula-stacho merged commit 6765079 into main Feb 20, 2025
37 checks passed
@paula-stacho paula-stacho deleted the COMPASS-9003 branch February 20, 2025 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants