test(sandbox): fix sandbox tests after protocol change COMPASS-8976 #6738
Conversation
Anemy
left a comment
Anemy
left a comment
There was a problem hiding this comment.
lgtm, the check is failing though so we should fix that first
| } else if (typeByte === MESSAGE_TYPE.BINARY) { | ||
| return message.subarray(1); | ||
| } else { | ||
| console.error('message does not have valid type byte "%s":', message); |
There was a problem hiding this comment.
The check script for this package is failing because of the no-console lint rule:
error Unexpected console statement no-console
To try it locally you can run npm run check in the packages/compass-web folder.
If these are useful we could add eslint ignores. Do we want to know when this happens though? Would it be worth doing a more prominent error here so folks run into it?
Also just noticed is that : at the end of the message extra?
There's another of these in ws-proxy.
There was a problem hiding this comment.
Yeah I think it's important enough to leave since it would mean the protocol really screwed up OR some very unexpected type of message is coming through the pipeline. I'll add // eslint-disable-next-line no-console. And thanks for the : catch! Removing
Description
Updating sandbox to follow websocket protocol changes in MMS
Checklist
Types of changes