From 855ba685034ac3f849f8c6d9c763d0c76b53da23 Mon Sep 17 00:00:00 2001 From: Daniel Echlin Date: Thu, 6 Mar 2025 10:39:55 -0500 Subject: [PATCH 1/4] code --- scripts/update-electron.js | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/scripts/update-electron.js b/scripts/update-electron.js index fde6b285116..bbcf1304081 100644 --- a/scripts/update-electron.js +++ b/scripts/update-electron.js @@ -100,7 +100,9 @@ async function main() { electronVersionRange ); - const latestNodeAbiVersion = await getLatestVersion('node-abi'); + + // Latest version of node-abi depends on Compass 22 + // const latestNodeAbiVersion = await getLatestVersion('node-abi'); const latestElectronRemoteVersion = await getLatestVersion( '@electron/remote' ); @@ -114,7 +116,7 @@ async function main() { ); const newVersions = { - 'node-abi': `^${latestNodeAbiVersion}`, + // 'node-abi': `^${latestNodeAbiVersion}`, '@electron/remote': `^${latestElectronRemoteVersion}`, '@electron/rebuild': `^${latestElectronRebuildVersion}`, electron: `^${latestElectronVersion}`, From 48428afb84bf57a7ee4f1b3ba1a1e19ab251ddc0 Mon Sep 17 00:00:00 2001 From: Daniel Echlin Date: Thu, 6 Mar 2025 10:41:48 -0500 Subject: [PATCH 2/4] empty From 986ef9cb8c80e475e83c09c1ce161684789fd87e Mon Sep 17 00:00:00 2001 From: djechlin-mongodb <132293929+djechlin-mongodb@users.noreply.github.com> Date: Thu, 6 Mar 2025 12:59:13 -0500 Subject: [PATCH 3/4] Update scripts/update-electron.js Co-authored-by: Sergey Petushkov --- scripts/update-electron.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/update-electron.js b/scripts/update-electron.js index bbcf1304081..70e5acc826f 100644 --- a/scripts/update-electron.js +++ b/scripts/update-electron.js @@ -101,7 +101,7 @@ async function main() { ); - // Latest version of node-abi depends on Compass 22 + // TODO(ticket): Latest version of node-abi depends on Node.js 22. We are on 20 and will stay on this version until our version of Electron is updated along with the monorepo expected engines version. Uncomment this when we can update // const latestNodeAbiVersion = await getLatestVersion('node-abi'); const latestElectronRemoteVersion = await getLatestVersion( '@electron/remote' From 6d5025186288f3a95ec74f49ac0f3fccbdbbb450 Mon Sep 17 00:00:00 2001 From: Daniel Echlin Date: Thu, 6 Mar 2025 13:00:22 -0500 Subject: [PATCH 4/4] plug in ticket --- scripts/update-electron.js | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/scripts/update-electron.js b/scripts/update-electron.js index 70e5acc826f..07c37c9f4f9 100644 --- a/scripts/update-electron.js +++ b/scripts/update-electron.js @@ -100,8 +100,7 @@ async function main() { electronVersionRange ); - - // TODO(ticket): Latest version of node-abi depends on Node.js 22. We are on 20 and will stay on this version until our version of Electron is updated along with the monorepo expected engines version. Uncomment this when we can update + // TODO(COMPASS-9098): Latest version of node-abi depends on Node.js 22. We are on 20 and will stay on this version until our version of Electron is updated along with the monorepo expected engines version. Uncomment this when we can update // const latestNodeAbiVersion = await getLatestVersion('node-abi'); const latestElectronRemoteVersion = await getLatestVersion( '@electron/remote'