Skip to content

chore(release): unblock workflows for update electron COMPASS-9075 #6779

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 6, 2025
Merged

chore(release): unblock workflows for update electron COMPASS-9075 #6779

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
855ba68
code
djechlin-mongodb Mar 6, 2025
48428af
empty
djechlin-mongodb Mar 6, 2025
986ef9c
Update scripts/update-electron.js
djechlin-mongodb Mar 6, 2025
f8c8e5d
Merge branch 'COMPASS-9075-electron-bumps' of github.com:mongodb-js/c…
djechlin-mongodb Mar 6, 2025
6d50251
plug in ticket
djechlin-mongodb Mar 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions scripts/update-electron.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,8 @@ async function main() {
electronVersionRange
);

const latestNodeAbiVersion = await getLatestVersion('node-abi');
// TODO(COMPASS-9098): Latest version of node-abi depends on Node.js 22. We are on 20 and will stay on this version until our version of Electron is updated along with the monorepo expected engines version. Uncomment this when we can update
// const latestNodeAbiVersion = await getLatestVersion('node-abi');
const latestElectronRemoteVersion = await getLatestVersion(
'@electron/remote'
);
Expand All @@ -114,7 +115,7 @@ async function main() {
);

const newVersions = {
'node-abi': `^${latestNodeAbiVersion}`,
// 'node-abi': `^${latestNodeAbiVersion}`,
'@electron/remote': `^${latestElectronRemoteVersion}`,
'@electron/rebuild': `^${latestElectronRebuildVersion}`,
electron: `^${latestElectronVersion}`,
Expand Down