Skip to content

Conversation

@gribnoysup
Copy link
Collaborator

This re-enables the update generated task with some safeguards added to make sure that hopefully never start spamming those automatic commits again, in particular:

  • Check that the previous commit was not autogenerated by the same task by checking the title (these runs are still allowed for the cron job)
  • Format autogenerated files before commiting them. This should make sure that empty commits don't happen
  • Check that commit is not empty before pushing it back to main. Seems like the way precommit hooks interact with git empty commit check allows empty commit to happen even if the flag enabling them is not passed. I'm changing the logic here allowing empty commits and explicitly checking that it's not empty before pushing, this should make sure that even if we change the precommit in the future and we start once again generating empty commits by accident, this task would always be able to skip pushes in those cases

@github-actions github-actions bot added the fix label Mar 28, 2025
@gribnoysup gribnoysup added the no-title-validation Skips validation of PR titles (conventional commit adherence + JIRA ticket inclusion) label Mar 28, 2025
…ip task when previous commit was also generated by it
@gribnoysup gribnoysup force-pushed the fix-update-generated-files branch from d5bb069 to 8cd4066 Compare March 28, 2025 09:58
@gribnoysup gribnoysup merged commit 4562bb6 into main Mar 28, 2025
5 of 7 checks passed
@gribnoysup gribnoysup deleted the fix-update-generated-files branch March 28, 2025 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fix no-title-validation Skips validation of PR titles (conventional commit adherence + JIRA ticket inclusion)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants