fix: semver sort the releases latest first before picking the first non-draft of the relevant channel #6838
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…aft of the relevant channel
lerouxb
added
bug
no release notes
paula-stacho
approved these changes
Apr 4, 2025
Collaborator
paula-stacho
left a comment
paula-stacho
left a comment
There was a problem hiding this comment.
Such a classic 😅
Is this a known issue with github, or it's a non issue because it doesn't promise a particular order?
Contributor
Author
|
Prereleases aren't very well specified by semver and there are just loads of issues like this even within one implementation, let alone across multiple for different languages. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub's REST API returns releases sorted incorrectly, so
1.45.5-beta.9appears before1.45.5-beta.10. We then pick the first non-draft of the relevant channel as the latest one for the manifest on the download centre and end up with .9 and not .10.This sorts the releases with semver first.
I tested this by just putting the code in a separate file and running it there, printing to the console. Once this is merged we can just re-run the most recent action that used this code and that should update the download centre correctly.