fix(web): Provide an actionable error message on DE errors CLOUDP-313461 #6907
+14
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnjackweir
approved these changes
May 8, 2025
Collaborator
johnjackweir
left a comment
johnjackweir
left a comment
There was a problem hiding this comment.
Generally we should have a unit test, especially for tricky things like regexes
I'm ok with this as is while we're trying to get MDE out the door
| const httpCodePattern = /\b(4\d{2}|5\d{2})\b/; // Matches HTTP codes 400-599 anywhere in the string | ||
|
|
||
| if (internalCodePattern.test(error) || httpCodePattern.test(error)) { | ||
| return 'Sorry, an unexpected error has occurred. Try refreshing the page or reporting the issue if it persists.'; |
Collaborator
There was a problem hiding this comment.
Nitpick but let's keep it as consistent with ye olde DE as possible
"We're sorry, an unexpected error has occurred. Please try again."
nbbeeken
changed the title
nvs119
changed the title
nvs119
changed the title
nvs119
added
release notes
and removed
no release notes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Matching on internal code patterns (CAPS_UNDERSCORE_WITH_COLON:) and HTTP codes 400-599 anywhere in the string. Wanted to make this more general but the Indexes page was where I saw the 403 error from filter, so followed it up to the regular-indexes modules.
error without sanitization, in console:
Motivation and Context
Open Questions
Dependents
Types of changes