chore(webpack, web): add saslprep no-op alias for webpack bundle web #6911
Conversation
Anemy
added
the
no-title-validation
nbbeeken
left a comment
nbbeeken
left a comment
There was a problem hiding this comment.
LGTM as is, suggestion about the export
|
I need to look into the test that's failing. Might be that our testing is using connection strings that use this. I'm thinking we might want to more explicitly throw here when the polyfill is used with a message indicating it's not supported and why. |
|
|
||
| it('can connect to an Atlas replicaset without srv', async function () { | ||
| if (!hasAtlasEnvironmentVariables()) { | ||
| if (!hasAtlasEnvironmentVariables() || TEST_COMPASS_WEB) { |
There was a problem hiding this comment.
Please don't skip those, most of our web tests will use the user-pass based auth, let's rather exclude sasl prep only for published bundle, and not for one that will be compiled for tests
There was a problem hiding this comment.
Good call. Updated the webpack to only run on production with the comment.
|
Merged to unblock compass-web package bundling size restriction so we can release new versions of that. @gribnoysup if the changes don't make sense feel free to revert, or I can make a follow up pr. |
We're hitting the 10mb limit for the bundle:
compass/packages/compass-web/webpack.config.js
Lines 18 to 23 in 5421da4
These changes bring the size back down a bit.
npm run analyzein thecompass-webpackage for webpack analysis.Related slack thread https://mongodb.slack.com/archives/G2L10JAV7/p1746808113154329