Skip to content

fix(e2e-tests): wait for diagram nodes to be visible COMPASS-9627 #7141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 29, 2025
Merged

fix(e2e-tests): wait for diagram nodes to be visible COMPASS-9627 #7141

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ef82d98
move to exact target
mabaasit Jul 24, 2025
3694661
revert change
mabaasit Jul 28, 2025
b3efa24
wait for nodes
mabaasit Jul 28, 2025
48d70d4
Merge branch 'main' into fix-diagram-drag-in-tests
mabaasit Jul 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions packages/compass-e2e-tests/tests/data-modeling-tab.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,10 +105,7 @@ async function moveNode(

await browser
.action('pointer')
.move({
x: Math.round(startPosition.x + nodeSize.width / 2),
y: Math.round(startPosition.y + nodeSize.height / 2),
})
.move({ origin: node, x: nodeSize.width / 2, y: nodeSize.height / 2 })
Copy link

Copilot AI Jul 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The division operations nodeSize.width / 2 and nodeSize.height / 2 could result in fractional pixel values. Consider using Math.round() to ensure precise positioning, similar to the original implementation.

Suggested change
.move({ origin: node, x: nodeSize.width / 2, y: nodeSize.height / 2 })
.move({ origin: node, x: Math.round(nodeSize.width / 2), y: Math.round(nodeSize.height / 2) })

Copilot uses AI. Check for mistakes.
Copy link
Collaborator

@paula-stacho paula-stacho Jul 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot has a point here, I think I've seen errors before I added the rounding

.down({ button: 0 }) // Left mouse button
.move({ ...coordinates, duration: 1000, origin: 'pointer' })
.pause(1000)
Expand Down
Loading