chore(compass-assistant): remove drawer padding and fix auto-scroll COMPASS-9757 #7274
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This: 1. Removes padding from Drawer (aligning with upcoming `hasPadding` property) and adjusts the drawer sections accordingly. 2. Removes MessageFeed in favor of a custom div for scrolling. LG currently uses a JavaScript-based mechanism for autoscroll which is janky and has many bugs which were noted during the last bug bug bash. They are aware of this and looking to change that so this will likely reach their implementation as well. Some things we're missing out on at this stage: 1. "Scroll to bottom" button: This button currently has bugs with appearing even when there is no content to scroll and I believe the scroll behavior improvements outweight the benefits of having this. 2. Shadow at the top when scrolling.
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the compass-assistant component to improve scrolling behavior and remove drawer padding. The changes replace LeafyGreen's MessageFeed component with a custom scrolling implementation using flexbox and reverse column direction for better auto-scroll functionality.
Key changes:
- Adds a
hasPaddingproperty to the Drawer component with default valuetrue - Replaces MessageFeed with a custom div using
flex-direction: column-reversefor auto-scroll - Adjusts drawer section styling to remove negative margins that compensated for drawer padding
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/compass-components/src/components/drawer/drawer/drawer.types.ts | Adds optional hasPadding property to DrawerProps interface |
| packages/compass-components/src/components/drawer/drawer/drawer.tsx | Implements conditional padding removal based on hasPadding prop |
| packages/compass-components/src/components/drawer/drawer-toolbar-layout/drawer-toolbar-layout-container.tsx | Sets hasPadding={false} for the drawer instance |
| packages/compass-data-modeling/src/components/drawer/drawer-section-components.tsx | Removes negative margins that compensated for drawer padding |
| packages/compass-assistant/src/assistant-chat.tsx | Replaces MessageFeed with custom scrolling div and reverses message order |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
gagik
added
the
no-title-validation
lerouxb
approved these changes
Sep 3, 2025
gagik
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This...
hasPaddingproperty) and adjusts the drawer sections accordingly.Some things we're missing out on at this stage: