feat(crud): add tooltip for N/A count COMPASS-10076 #7568
+25
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds a tooltip to the "N/A" count display in the CRUD toolbar to explain why the count might be unavailable. When the count operation fails or exceeds the maxTimeMS limit, users can hover over the underlined "N/A" text to see an explanation.
Key changes:
- Exported the
COUNT_MAX_TIME_MS_CAPconstant to make it reusable across components - Added a tooltip component with explanatory text for unavailable counts
- Refactored the count display logic to conditionally render the tooltip when count is unavailable
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| packages/compass-crud/src/stores/crud-store.ts | Exported the COUNT_MAX_TIME_MS_CAP constant for use in tooltip message |
| packages/compass-crud/src/components/crud-toolbar.tsx | Added tooltip functionality with styling for the N/A count display |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
lerouxb
approved these changes
Nov 17, 2025
mabaasit
reviewed
Nov 17, 2025
| const INCREASE_MAX_TIME_MS_HINT = | ||
| 'Operation exceeded time limit. Please try increasing the maxTimeMS for the query in the expanded filter options.'; | ||
|
|
||
| const COUNT_UNAVAILABLE_TOOLTIP = `The count is not available for this query. This can happen when the count operation fails or exceeds the maxTimeMS of ${COUNT_MAX_TIME_MS_CAP}.`; |
Collaborator
There was a problem hiding this comment.
We cap maxTimeMS and if a user has set it to lower value in preferences, should we show that instead? When running count, we call capMaxTimeMSAtPreferenceLimit to get actual value we use.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
COMPASS-10076
Asking about the text in slack thread https://mongodb.slack.com/archives/GDTJXPHD0/p1762874210679479