Skip to content

Commit 4dfcd8c

Browse files
authored
fix(ci): use [email protected] to avoid failing silently (#508)
Before even if a lerna npm task failed, lerna would still exit with success and so would the CI task. This was because NPM v8 not sending the correct exit code. NPM v9 fixed this so this updates it to that.
1 parent bf3897d commit 4dfcd8c

File tree

3 files changed

+7
-3
lines changed

3 files changed

+7
-3
lines changed

.github/workflows/check-test.yaml

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,10 @@ on:
1414
permissions:
1515
contents: read # we just need to checkout the repo
1616

17+
concurrency:
18+
group: ${{ github.workflow }}-${{ github.ref }}
19+
cancel-in-progress: true
20+
1721
# A workflow run is made up of one or more jobs that can run sequentially or in parallel
1822
jobs:
1923
check-and-test:
@@ -60,7 +64,7 @@ jobs:
6064
cache: "npm"
6165

6266
- name: Install npm
63-
run: npm install -g npm@8
67+
run: npm install -g npm@9
6468

6569
- name: Use [email protected]
6670
# Default Python (3.12) doesn't have support for distutils

package-lock.json

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
},
1111
"engines": {
1212
"node": ">=14.17.5",
13-
"npm": ">=7.16.0"
13+
"npm": ">=9.0.0"
1414
},
1515
"workspaces": [
1616
"packages/*",

0 commit comments

Comments
 (0)