WIP

Author: addaleax

package-lock.json

@@ -64,12 +64,14 @@
     "chai": "^4.3.6",
     "depcheck": "^1.4.1",
     "duplexpair": "^1.0.2",
+    "electron": "^31.2.1",
     "eslint": "^7.25.0",
     "gen-esm-wrapper": "^1.1.0",
     "mocha": "^8.4.0",
     "nyc": "^15.1.0",
     "prettier": "^2.3.2",
     "sinon": "^9.2.3",
-    "typescript": "^5.0.4"
+    "typescript": "^5.0.4",
+    "xvfb-maybe": "^0.2.1"
   }
 }

packages/devtools-proxy-support/package.json

@@ -93,7 +93,7 @@ describe('createAgent', function () {
   });
 
   context('http proxy', function () {
-    it('can connect to a http proxy without auth', async function () {
+    it('can connect to an http proxy without auth', async function () {
       const res = await get(
         'http://example.com/hello',
         createAgent({ proxy: `http://127.0.0.1:${setup.httpProxyPort}` })
@@ -104,7 +104,7 @@ describe('createAgent', function () {
       ]);
     });
 
-    it('can connect to a http proxy with successful auth', async function () {
+    it('can connect to an http proxy with successful auth', async function () {
       setup.authHandler = sinon.stub().returns(true);
 
       const res = await get(
@@ -120,7 +120,7 @@ describe('createAgent', function () {
       expect(setup.authHandler).to.have.been.calledOnceWith('foo', 'bar');
     });
 
-    it('fails to connect to a http proxy with unsuccessful auth', async function () {
+    it('fails to connect to an http proxy with unsuccessful auth', async function () {
       setup.authHandler = sinon.stub().returns(false);
 
       const res = await get(
@@ -134,7 +134,7 @@ describe('createAgent', function () {
   });
 
   context('https/connect proxy', function () {
-    it('can connect to a https proxy without auth', async function () {
+    it('can connect to an https proxy without auth', async function () {
       const res = await get(
         'https://example.com/hello',
         createAgent({ proxy: `http://127.0.0.1:${setup.httpsProxyPort}` })
@@ -145,7 +145,7 @@ describe('createAgent', function () {
       ]);
     });
 
-    it('can connect to a https proxy with successful auth', async function () {
+    it('can connect to an https proxy with successful auth', async function () {
       setup.authHandler = sinon.stub().returns(true);
 
       const res = await get(
@@ -161,7 +161,7 @@ describe('createAgent', function () {
       expect(setup.authHandler).to.have.been.calledOnceWith('foo', 'bar');
     });
 
-    it('fails to connect to a https proxy with unsuccessful auth', async function () {
+    it('fails to connect to an https proxy with unsuccessful auth', async function () {
       setup.authHandler = sinon.stub().returns(false);
 
       const res = await get(

packages/devtools-proxy-support/src/agent.spec.ts

@@ -15,6 +15,7 @@ describe('createFetch', function () {
   });
 
   context('HTTP calls', function () {
+    let fetch: ReturnType<typeof createFetch>;
     let setup: HTTPServerProxyTestSetup;
 
     beforeEach(async function () {
@@ -24,6 +25,7 @@ describe('createFetch', function () {
 
     afterEach(async function () {
       await setup.teardown();
+      fetch?.agent?.destroy?.();
     });
 
     it('provides a node-fetch-like HTTP functionality', async function () {
@@ -34,7 +36,7 @@ describe('createFetch', function () {
     });
 
     it('makes use of SSH proxy support when instructed to do so', async function () {
-      const fetch = createFetch({
+      fetch = createFetch({
         proxy: `ssh://[email protected]:${setup.sshProxyPort}`,
       });
       const response = await fetch(
@@ -49,42 +51,58 @@ describe('createFetch', function () {
           srcPort: 0,
         },
       ]);
-      fetch.agent?.destroy?.();
     });
 
     it('makes use of HTTP proxy support when instructed to do so', async function () {
-      const fetch = createFetch({
+      fetch = createFetch({
         proxy: `http://127.0.0.1:${setup.httpProxyPort}`,
       });
       const response = await fetch(
         `http://localhost:${setup.httpServerPort}/test`
       );
       expect(await response.text()).to.equal('OK /test');
-      fetch.agent?.destroy?.();
     });
 
     it('makes use of HTTPS proxy support when instructed to do so', async function () {
-      const fetch = createFetch({
+      fetch = createFetch({
         proxy: `http://127.0.0.1:${setup.httpsProxyPort}`,
         ca: setup.tlsOptions.ca,
       });
       const response = await fetch(
         `https://localhost:${setup.httpsServerPort}/test`
       );
       expect(await response.text()).to.equal('OK /test');
-      fetch.agent?.destroy?.();
     });
 
     it('makes use of Socks5 proxy support when instructed to do so', async function () {
       setup.socks5AuthNone();
-      const fetch = createFetch({
+      fetch = createFetch({
         proxy: `socks5://127.0.0.1:${setup.socks5ProxyPort}`,
       });
       const response = await fetch(
         `http://localhost:${setup.httpServerPort}/test`
       );
       expect(await response.text()).to.equal('OK /test');
-      fetch.agent?.destroy?.();
+    });
+
+    it('makes use of PAC-based proxy support when instructed to do so', async function () {
+      setup.socks5AuthNone();
+      fetch = createFetch({
+        proxy: `pac+http://127.0.0.1:${setup.httpServerPort}/pac`,
+      });
+      const response = await fetch(
+        `http://localhost:${setup.httpsServerPort}/test`
+      );
+      expect(await response.text()).to.equal('OK /test');
+
+      try {
+        await fetch(`http://pac-invalidproxy/test`);
+        expect.fail('missed exception');
+      } catch (err) {
+        expect(err.message).to.include(
+          'Failed to establish a socket connection to proxies: ["SOCKS5 127.0.0.1:1"]'
+        );
+      }
     });
   });
 });