Skip to content

Commit d3ddf7e

Browse files
committed
fixup: allow empty string as secrets
1 parent 0a24b9f commit d3ddf7e

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

packages/devtools-proxy-support/src/proxy-options.ts

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -287,8 +287,9 @@ export function mergeProxySecrets({
287287
proxyOptions: Readonly<DevtoolsProxyOptions>;
288288
secrets: DevtoolsProxyOptionsSecrets;
289289
}): DevtoolsProxyOptions {
290-
const parsedSecrets: DevtoolsProxyOptionsSecretsInternal =
291-
JSON.parse(secrets);
290+
const parsedSecrets: DevtoolsProxyOptionsSecretsInternal = JSON.parse(
291+
secrets || '{}'
292+
);
292293
if (
293294
(parsedSecrets.username || parsedSecrets.password) &&
294295
proxyOptions.proxy

0 commit comments

Comments
 (0)