From aeb3ccdbfc1455c88873d84b6afe3dbbc6523b4c Mon Sep 17 00:00:00 2001 From: gagik Date: Tue, 11 Feb 2025 14:21:34 +0100 Subject: [PATCH] fix(ci): use npm@9.x to avoid failing silently Currently even if a lerna npm task fails, lerna still exits with success and so does the CI task. This is because NPM v8 not sending the correct exit code. NPM v9 fixed this so this updates to that. --- .github/workflows/check-test.yaml | 6 +++++- package-lock.json | 2 +- package.json | 2 +- 3 files changed, 7 insertions(+), 3 deletions(-) diff --git a/.github/workflows/check-test.yaml b/.github/workflows/check-test.yaml index c8c1f308..086a3788 100644 --- a/.github/workflows/check-test.yaml +++ b/.github/workflows/check-test.yaml @@ -14,6 +14,10 @@ on: permissions: contents: read # we just need to checkout the repo +concurrency: + group: ${{ github.workflow }}-${{ github.ref }} + cancel-in-progress: true + # A workflow run is made up of one or more jobs that can run sequentially or in parallel jobs: check-and-test: @@ -60,7 +64,7 @@ jobs: cache: "npm" - name: Install npm - run: npm install -g npm@8 + run: npm install -g npm@9 - name: Use python@3.11 # Default Python (3.12) doesn't have support for distutils diff --git a/package-lock.json b/package-lock.json index 5a60b674..6350db5c 100644 --- a/package-lock.json +++ b/package-lock.json @@ -24,7 +24,7 @@ }, "engines": { "node": ">=14.17.5", - "npm": ">=7.16.0" + "npm": ">=9.0.0" } }, "configs/eslint-config-devtools": { diff --git a/package.json b/package.json index d41a8a4c..0d37a180 100644 --- a/package.json +++ b/package.json @@ -10,7 +10,7 @@ }, "engines": { "node": ">=14.17.5", - "npm": ">=7.16.0" + "npm": ">=9.0.0" }, "workspaces": [ "packages/*",