fix(native-machine-id): replace bindings dependency with explicit paths #534
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Use explicit paths for requiring as that works better with bundlers - No need to use `bindings` as the alternative is simpler Signed-off-by: Sebastian Malton <[email protected]>
addaleax
approved these changes
May 6, 2025
addaleax
changed the title
addaleax
force-pushed
the
fix-support-for-electron
branch
from
ce35690 to
537b950
Compare
Collaborator
|
@Nokel81 Published in |
Contributor
Author
|
Thanks for the quick response time! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
bindingsas the alternative is simplerOpen Questions
Checklist