v8 13.5.212.10

Add livechecks for resources. These may not work for autobump as V8
uses git revisions which are not monotonically increasing. However, it
should at least help provide all necessary revision updates in one
command: `brew livecheck --resources v8`

Co-authored-by: Michael Cho <[email protected]>

Author: chenrui333

Formula/v/v8.rb

@@ -2,8 +2,9 @@ class V8 < Formula
   desc "Google's JavaScript engine"
   homepage "https://v8.dev/docs"
   # Track V8 version from Chrome stable: https://chromiumdash.appspot.com/releases?platform=Mac
-  url "https://github.com/v8/v8/archive/refs/tags/13.4.114.19.tar.gz"
-  sha256 "6ed878b3bb97b38431ec427d8b3a837c579dc5bafb8e8b706de85f160037197c"
+  # Check `brew livecheck --resources v8` for any resource updates
+  url "https://github.com/v8/v8/archive/refs/tags/13.5.212.10.tar.gz"
+  sha256 "2c47b3de22591f4384f75aa462301eb9fdb9d661ee07f73cab95a89d0a75d5ae"
   license "BSD-3-Clause"
 
   livecheck do
@@ -31,17 +32,18 @@ class V8 < Formula
     sha256 cellar: :any_skip_relocation, x86_64_linux:  "4424792b53407e75eaa8c774874f0f0ef5bed25efcf5473fca62c2dce2828461"
   end
 
+  depends_on "llvm" => :build
   depends_on "ninja" => :build
   depends_on xcode: ["10.0", :build] # for xcodebuild, min version required by v8
 
   uses_from_macos "python" => :build
 
   on_macos do
-    depends_on "llvm" => :build
     depends_on "llvm" if DevelopmentTools.clang_build_version <= 1400
   end
 
   on_linux do
+    depends_on "lld" => :build
     depends_on "pkgconf" => :build
     depends_on "glib"
   end
@@ -50,79 +52,162 @@ class V8 < Formula
   # e.g. for CIPD dependency gn: https://chromium.googlesource.com/v8/v8.git/+/refs/tags/<version>/DEPS#74
   resource "gn" do
     url "https://gn.googlesource.com/gn.git",
-        revision: "ed1abc107815210dc66ec439542bee2f6cbabc00"
+        revision: "4a8016dc391553fa1644c0740cc04eaac844121e"
+    version "4a8016dc391553fa1644c0740cc04eaac844121e"
+
+    livecheck do
+      url "https://raw.githubusercontent.com/v8/v8/refs/tags/#{LATEST_VERSION}/DEPS"
+      regex(/["']gn_version["']:\s*["']git_revision:([0-9a-f]+)["']/i)
+    end
   end
 
-  resource "v8/build" do
+  resource "build" do
     url "https://chromium.googlesource.com/chromium/src/build.git",
-        revision: "a9640b2af4c541cbe6b716f447315d487351ae46"
+        revision: "efb3303345a5501074564393470197a904b4afb7"
+    version "efb3303345a5501074564393470197a904b4afb7"
+
+    livecheck do
+      url "https://raw.githubusercontent.com/v8/v8/refs/tags/#{LATEST_VERSION}/DEPS"
+      regex(%r{["']/chromium/src/build\.git["']\s*\+\s*["']@["']\s*\+\s*["']([0-9a-f]+)["']}i)
+    end
+  end
+
+  resource "buildtools" do
+    url "https://chromium.googlesource.com/chromium/src/buildtools.git",
+        revision: "b248db940ef3dd7e5f4694ebf4d8a3f67aa0086d"
+    version "b248db940ef3dd7e5f4694ebf4d8a3f67aa0086d"
+
+    livecheck do
+      url "https://raw.githubusercontent.com/v8/v8/refs/tags/#{LATEST_VERSION}/DEPS"
+      regex(%r{["']/chromium/src/buildtools\.git["']\s*\+\s*["']@["']\s*\+\s*["']([0-9a-f]+)["']}i)
+    end
+  end
+
+  resource "third_party/abseil-cpp" do
+    url "https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp.git",
+        revision: "2705c6655c0008cc3fb152dae27890d44bc335f1"
+    version "2705c6655c0008cc3fb152dae27890d44bc335f1"
+
+    livecheck do
+      url "https://raw.githubusercontent.com/v8/v8/refs/tags/#{LATEST_VERSION}/DEPS"
+      regex(%r{["']/chromium/src/third_party/abseil-cpp\.git["']\s*\+\s*["']@["']\s*\+\s*["']([0-9a-f]+)["']}i)
+    end
   end
 
-  resource "v8/third_party/fast_float/src" do
+  resource "third_party/fast_float/src" do
     url "https://chromium.googlesource.com/external/github.com/fastfloat/fast_float.git",
         revision: "cb1d42aaa1e14b09e1452cfdef373d051b8c02a4"
+    version "cb1d42aaa1e14b09e1452cfdef373d051b8c02a4"
+
+    livecheck do
+      url "https://raw.githubusercontent.com/v8/v8/refs/tags/#{LATEST_VERSION}/DEPS"
+      regex(%r{["']/external/github.com/fastfloat/fast_float\.git["']\s*\+\s*["']@["']\s*\+\s*["']([0-9a-f]+)["']}i)
+    end
   end
 
-  resource "v8/third_party/fp16/src" do
+  resource "third_party/fp16/src" do
     url "https://chromium.googlesource.com/external/github.com/Maratyszcza/FP16.git",
         revision: "0a92994d729ff76a58f692d3028ca1b64b145d91"
+    version "0a92994d729ff76a58f692d3028ca1b64b145d91"
+
+    livecheck do
+      url "https://raw.githubusercontent.com/v8/v8/refs/tags/#{LATEST_VERSION}/DEPS"
+      regex(%r{["']/external/github.com/Maratyszcza/FP16\.git["']\s*\+\s*["']@["']\s*\+\s*["']([0-9a-f]+)["']}i)
+    end
   end
 
-  resource "v8/third_party/googletest/src" do
+  resource "third_party/googletest/src" do
     url "https://chromium.googlesource.com/external/github.com/google/googletest.git",
-        revision: "e235eb34c6c4fed790ccdad4b16394301360dcd4"
+        revision: "24a9e940d481f992ba852599c78bb2217362847b"
+    version "24a9e940d481f992ba852599c78bb2217362847b"
+
+    livecheck do
+      url "https://raw.githubusercontent.com/v8/v8/refs/tags/#{LATEST_VERSION}/DEPS"
+      regex(%r{["']/external/github.com/google/googletest\.git["']\s*\+\s*["']@["']\s*\+\s*["']([0-9a-f]+)["']}i)
+    end
   end
 
   resource "third_party/highway/src" do
     url "https://chromium.googlesource.com/external/github.com/google/highway.git",
         revision: "00fe003dac355b979f36157f9407c7c46448958e"
+    version "00fe003dac355b979f36157f9407c7c46448958e"
+
+    livecheck do
+      url "https://raw.githubusercontent.com/v8/v8/refs/tags/#{LATEST_VERSION}/DEPS"
+      regex(%r{["']/external/github.com/google/highway\.git["']\s*\+\s*["']@["']\s*\+\s*["']([0-9a-f]+)["']}i)
+    end
   end
 
-  resource "v8/third_party/icu" do
+  resource "third_party/icu" do
     url "https://chromium.googlesource.com/chromium/deps/icu.git",
-        revision: "bbccc2f6efc1b825de5f2c903c48be685cd0cf22"
+        revision: "d30b7b0bb3829f2e220df403ed461a1ede78b774"
+    version "d30b7b0bb3829f2e220df403ed461a1ede78b774"
+
+    livecheck do
+      url "https://raw.githubusercontent.com/v8/v8/refs/tags/#{LATEST_VERSION}/DEPS"
+      regex(%r{["']/chromium/deps/icu\.git["']\s*\+\s*["']@["']\s*\+\s*["']([0-9a-f]+)["']}i)
+    end
   end
 
-  resource "v8/third_party/jinja2" do
+  resource "third_party/jinja2" do
     url "https://chromium.googlesource.com/chromium/src/third_party/jinja2.git",
         revision: "5e1ee241ab04b38889f8d517f2da8b3df7cfbd9a"
+    version "5e1ee241ab04b38889f8d517f2da8b3df7cfbd9a"
+
+    livecheck do
+      url "https://raw.githubusercontent.com/v8/v8/refs/tags/#{LATEST_VERSION}/DEPS"
+      regex(%r{["']/chromium/src/third_party/jinja2\.git["']\s*\+\s*["']@["']\s*\+\s*["']([0-9a-f]+)["']}i)
+    end
   end
 
-  resource "v8/third_party/markupsafe" do
+  resource "third_party/markupsafe" do
     url "https://chromium.googlesource.com/chromium/src/third_party/markupsafe.git",
         revision: "9f8efc8637f847ab1ba984212598e6fb9cf1b3d4"
-  end
+    version "9f8efc8637f847ab1ba984212598e6fb9cf1b3d4"
 
-  resource "v8/third_party/zlib" do
-    url "https://chromium.googlesource.com/chromium/src/third_party/zlib.git",
-        revision: "5634698162b2182c350e4cb360a0f4dd7706afec"
+    livecheck do
+      url "https://raw.githubusercontent.com/v8/v8/refs/tags/#{LATEST_VERSION}/DEPS"
+      regex(%r{["']/chromium/src/third_party/markupsafe\.git["']\s*\+\s*["']@["']\s*\+\s*["']([0-9a-f]+)["']}i)
+    end
   end
 
-  resource "v8/third_party/abseil-cpp" do
-    url "https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp.git",
-        revision: "aaed376e01b9f98ff29f70fd47468b7e806e1639"
+  resource "third_party/partition_alloc" do
+    url "https://chromium.googlesource.com/chromium/src/base/allocator/partition_allocator.git",
+        revision: "46d880ff62f340854a5a70142b0abf604c7af221"
+    version "46d880ff62f340854a5a70142b0abf604c7af221"
+
+    livecheck do
+      url "https://raw.githubusercontent.com/v8/v8/refs/tags/#{LATEST_VERSION}/DEPS"
+      regex(/["']partition_alloc_version["']:\s*["']([0-9a-f]+)["']/i)
+    end
   end
 
-  resource "v8/third_party/simdutf" do
+  resource "third_party/simdutf" do
     url "https://chromium.googlesource.com/chromium/src/third_party/simdutf.git",
         revision: "5a9a2134b280c1b956ad68a0643797fe26dd1c94"
+    version "5a9a2134b280c1b956ad68a0643797fe26dd1c94"
+
+    livecheck do
+      url "https://raw.githubusercontent.com/v8/v8/refs/tags/#{LATEST_VERSION}/DEPS"
+      regex(%r{["']/chromium/src/third_party/simdutf["']\s*\+\s*["']@["']\s*\+\s*["']([0-9a-f]+)["']}i)
+    end
+  end
+
+  resource "third_party/zlib" do
+    url "https://chromium.googlesource.com/chromium/src/third_party/zlib.git",
+        revision: "788cb3c270e8700b425c7bdca1f9ce6b0c1400a9"
+    version "788cb3c270e8700b425c7bdca1f9ce6b0c1400a9"
+
+    livecheck do
+      url "https://raw.githubusercontent.com/v8/v8/refs/tags/#{LATEST_VERSION}/DEPS"
+      regex(%r{["']/chromium/src/third_party/zlib\.git["']\s*\+\s*["']@["']\s*\+\s*["']([0-9a-f]+)["']}i)
+    end
   end
 
   def install
-    (buildpath/"build").install resource("v8/build")
-    (buildpath/"third_party/jinja2").install resource("v8/third_party/jinja2")
-    (buildpath/"third_party/markupsafe").install resource("v8/third_party/markupsafe")
-    (buildpath/"third_party/fast_float/src").install resource("v8/third_party/fast_float/src")
-    (buildpath/"third_party/fp16/src").install resource("v8/third_party/fp16/src")
-    (buildpath/"third_party/googletest/src").install resource("v8/third_party/googletest/src")
-    (buildpath/"third_party/highway/src").install resource("third_party/highway/src")
-    (buildpath/"third_party/icu").install resource("v8/third_party/icu")
-    (buildpath/"third_party/zlib").install resource("v8/third_party/zlib")
-    (buildpath/"third_party/abseil-cpp").install resource("v8/third_party/abseil-cpp")
-    (buildpath/"third_party/simdutf").install resource("v8/third_party/simdutf")
+    resources.each { |r| r.stage(buildpath/r.name) }
 
     # Build gn from source and add it to the PATH
-    (buildpath/"gn").install resource("gn")
     cd "gn" do
       system "python3", "build/gen.py"
       system "ninja", "-C", "out/", "gn"
@@ -146,21 +231,23 @@ def install
       clang_use_chrome_plugins:     false, # disable the usage of Google's custom clang plugins
       use_custom_libcxx:            false, # uses system libc++ instead of Google's custom one
       treat_warnings_as_errors:     false, # ignore not yet supported clang argument warnings
-      use_lld:                      false, # upstream use LLD but this leads to build failure on ARM
     }
 
+    # uses Homebrew clang instead of Google clang
+    gn_args[:clang_base_path] = "\"#{Formula["llvm"].opt_prefix}\""
+    gn_args[:clang_version] = "\"#{Formula["llvm"].version.major}\""
+
     if OS.linux?
-      gn_args[:is_clang] = false # use GCC on Linux
+      ENV.llvm_clang
+      ENV["AR"] = DevelopmentTools.locate("ar")
+      ENV["NM"] = DevelopmentTools.locate("nm")
       gn_args[:use_sysroot] = false # don't use sysroot
       gn_args[:custom_toolchain] = "\"//build/toolchain/linux/unbundle:default\"" # uses system toolchain
       gn_args[:host_toolchain] = "\"//build/toolchain/linux/unbundle:default\"" # to respect passed LDFLAGS
-      ENV["AR"] = DevelopmentTools.locate("ar")
-      ENV["NM"] = DevelopmentTools.locate("nm")
       gn_args[:use_rbe] = false
     else
       ENV["DEVELOPER_DIR"] = ENV["HOMEBREW_DEVELOPER_DIR"] # help run xcodebuild when xcode-select is set to CLT
-      gn_args[:clang_base_path] = "\"#{Formula["llvm"].opt_prefix}\"" # uses Homebrew clang instead of Google clang
-      gn_args[:clang_version] = "\"#{Formula["llvm"].version.major}\""
+      gn_args[:use_lld] = false # upstream use LLD but this leads to build failure on ARM
       # Work around failure mixing newer `llvm` headers with older Xcode's libc++:
       # Undefined symbols for architecture x86_64:
       #   "std::__1::__libcpp_verbose_abort(char const*, ...)", referenced from: