Skip to content

Commit 04044d2

Browse files
authored
fix(NODE-6253): use runtime linking against system kerberos libraries by default (#188)
1 parent ec3ab7a commit 04044d2

File tree

3 files changed

+5
-5
lines changed

3 files changed

+5
-5
lines changed

.evergreen/config.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -124,7 +124,7 @@ tasks:
124124
commands:
125125
- func: run tests ubuntu
126126
vars:
127-
GYP_DEFINES: kerberos_use_rtld=true
127+
GYP_DEFINES: kerberos_use_rtld=false
128128
NPM_OPTIONS: --build-from-source
129129
- name: run-prebuild
130130
commands:

.github/scripts/build.mjs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ async function parseArguments() {
1919
const pkg = JSON.parse(await fs.readFile(resolveRoot('package.json'), 'utf8'));
2020

2121
const options = {
22-
'kerberos_use_rtld': { type: 'boolean', default: false },
22+
'kerberos_use_rtld': { type: 'boolean', default: true },
2323
help: { short: 'h', type: 'boolean', default: false }
2424
};
2525

@@ -66,8 +66,8 @@ async function buildBindings(args, pkg) {
6666
// it will also produce `./prebuilds/kerberos-vVERSION-napi-vNAPI_VERSION-OS-ARCH.tar.gz`.
6767

6868
let gypDefines = process.env.GYP_DEFINES ?? '';
69-
if (args.kerberos_use_rtld) {
70-
gypDefines += ' kerberos_use_rtld=true';
69+
if (!args.kerberos_use_rtld) {
70+
gypDefines += ' kerberos_use_rtld=false';
7171
}
7272

7373
gypDefines = gypDefines.trim();

binding.gyp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
],
1212
'variables': {
1313
'ARCH': '<(host_arch)',
14-
'kerberos_use_rtld%': 'false'
14+
'kerberos_use_rtld%': 'true'
1515
},
1616
'xcode_settings': {
1717
'GCC_ENABLE_CPP_EXCEPTIONS': 'YES',

0 commit comments

Comments
 (0)