Commit 5c3c384
committed
fix(NODE-7395): do not export mech_oid symbols
As described in the ticket, this fixes mongosh's build on x64 macOS
with Node.js 24, even though we haven't fully investigated why
that is the case.
Making these variables `static` is a good idea anyway since they
are not meant to be used by other compilation units or loaded
from the kerberos addon.
Without this patch, we receive:
[2026/01/15 12:18:50.271] ld: warning: alignment (2) of atom '__ZN13node_kerberos15spnego_mech_oidE' is too small and may result in unaligned pointers
[2026/01/15 12:18:50.271] ld: warning: alignment (2) of atom '__ZN13node_kerberos13krb5_mech_oidE' is too small and may result in unaligned pointers
[2026/01/15 12:18:50.946] ld: warning: pointer not aligned at address 0x10945A92E ('node_kerberos::krb5_mech_oid' + 4 from /private/tmp/m/boxednode/<REDACTED:notary_signing_key_name>/node-v24.12.0/out/Release/kerberos.a(kerberos_unix.o))
[2026/01/15 12:18:50.946] ld: warning: pointer not aligned at address 0x10945A942 ('node_kerberos::spnego_mech_oid' + 4 from /private/tmp/m/boxednode/<REDACTED:notary_signing_key_name>/node-v24.12.0/out/Release/kerberos.a(kerberos_unix.o))
[2026/01/15 12:18:51.115] ld: unaligned pointer(s) for architecture x86_64
[2026/01/15 12:18:51.115] clang++: error: linker command failed with exit code 1 (use -v to see invocation)1 parent 687aaf1 commit 5c3c384
1 file changed
+2
-2
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
11 | 11 | | |
12 | 12 | | |
13 | 13 | | |
14 | | - | |
| 14 | + | |
15 | 15 | | |
16 | 16 | | |
17 | | - | |
| 17 | + | |
18 | 18 | | |
19 | 19 | | |
20 | 20 | | |
| |||
0 commit comments