add back parameter validation

Author: baileympearson

lib/kerberos.js

@@ -42,6 +42,9 @@ const originalStep = KerberosClient.prototype.step;
  * @return {Promise<string>}
  */
 KerberosClient.prototype.step = async function step(challenge) {
+  if (typeof challenge !== 'string') {
+    throw new Error('parameter `challenge` must be a string.');
+  }
   return await promisify(originalStep.bind(this))(challenge);
 };
 
@@ -52,12 +55,20 @@ const originalWrap = KerberosClient.prototype.wrap;
  * @kind function
  * @memberof KerberosClient
  * @param {string} challenge The response returned after calling `unwrap`
- * @param {object} [options] Optional settings
+ * @param {object} [options] Options
  * @param {string} [options.user] The user to authorize
  * @param {boolean} [options.protect] Indicates if the wrap should request message confidentiality
  * @return {Promise<string>}
  */
-KerberosClient.prototype.wrap = async function wrap(challenge, options = {}) {
+KerberosClient.prototype.wrap = async function wrap(challenge, options) {
+  if (typeof challenge !== 'string') {
+    throw new Error('parameter `challenge` must be a string.');
+  }
+
+  // eslint-disable-next-line no-restricted-syntax
+  if (typeof challenge !== 'object' || challenge === null) {
+    throw new Error('parameter `challenge` must be an object.');
+  }
   return await promisify(originalWrap.bind(this))(challenge, options);
 };
 
@@ -71,6 +82,9 @@ const originalUnwrap = KerberosClient.prototype.unwrap;
  * @return {Promise<string>}
  */
 KerberosClient.prototype.unwrap = async function unwrap(challenge) {
+  if (typeof challenge !== 'string') {
+    throw new Error('parameter `challenge` must be a string.');
+  }
   return await promisify(originalUnwrap.bind(this))(challenge);
 };
 
@@ -93,6 +107,9 @@ const originalServerStep = KerberosServer.prototype.step;
  * @return {Promise<KerberosServer>}
  */
 KerberosServer.prototype.step = async function step(challenge) {
+  if (typeof challenge !== 'string') {
+    throw new Error('parameter `challenge` must be a string.');
+  }
   return await promisify(originalServerStep.bind(this))(challenge);
 };
 
@@ -121,6 +138,18 @@ KerberosServer.prototype.step = async function step(challenge) {
  * @return {Promise<null>} returns Promise that rejects if the password is invalid
  */
 async function checkPassword(username, password, service, defaultRealm) {
+  if (typeof username !== 'string') {
+    throw new Error('parameter `username` must be a string.');
+  }
+  if (typeof password !== 'string') {
+    throw new Error('parameter `password` must be a string.');
+  }
+  if (typeof service !== 'string') {
+    throw new Error('parameter `service` must be a string.');
+  }
+  if (defaultRealm && typeof defaultRealm !== 'string') {
+    throw new Error('if specified, parameter `defaultRealm` must be a string.');
+  }
   return await promisify(kerberos.checkPassword)(username, password, service, defaultRealm);
 }
 
@@ -135,6 +164,12 @@ async function checkPassword(username, password, service, defaultRealm) {
  * @return {Promise} returns Promise
  */
 async function principalDetails(service, hostname) {
+  if (typeof service !== 'string') {
+    throw new Error('parameter `service` must be a string.');
+  }
+  if (typeof hostname !== 'string') {
+    throw new Error('parameter `hostname` must be a string.');
+  }
   return await promisify(kerberos.principalDetails)(service, hostname);
 }
 
@@ -150,6 +185,9 @@ async function principalDetails(service, hostname) {
  * @return {Promise<KerberosClient>} returns Promise
  */
 async function initializeClient(service, options = { mechOID: GSS_C_NO_OID }) {
+  if (typeof service !== 'string') {
+    throw new Error('parameter `service` must be a string.');
+  }
   return await promisify(kerberos.initializeClient)(service, options);
 }
 
@@ -161,6 +199,9 @@ async function initializeClient(service, options = { mechOID: GSS_C_NO_OID }) {
  * @return {Promise<KerberosServer>} returns Promise
  */
 async function initializeServer(service) {
+  if (typeof service !== 'string') {
+    throw new Error('parameter `service` must be a string.');
+  }
   return await promisify(kerberos.initializeServer)(service);
 }