chore: PR feedback

Author: himanshusinghs

src/index.ts

@@ -42,7 +42,7 @@ import { packageInfo } from "./common/packageInfo.js";
 import { StdioRunner } from "./transports/stdio.js";
 import { StreamableHttpRunner } from "./transports/streamableHttp.js";
 import { systemCA } from "@mongodb-js/devtools-proxy-support";
-import type { CreateConnectionManagerFn } from "./transports/base.js";
+import type { ConnectionManagerFactoryFn } from "./transports/base.js";
 import { MCPConnectionManager } from "./common/connectionManager.js";
 
 async function main(): Promise<void> {
@@ -51,8 +51,8 @@ async function main(): Promise<void> {
     assertHelpMode();
     assertVersionMode();
 
-    const createConnectionManager: CreateConnectionManagerFn = ({ logger, deviceId }) =>
-        new MCPConnectionManager(config, driverOptions, logger, deviceId);
+    const createConnectionManager: ConnectionManagerFactoryFn = ({ logger, deviceId }) =>
+        Promise.resolve(new MCPConnectionManager(config, driverOptions, logger, deviceId));
 
     const transportRunner =
         config.transport === "stdio"

src/lib.ts

@@ -3,7 +3,7 @@ export { Session, type SessionOptions } from "./common/session.js";
 export { defaultUserConfig, type UserConfig } from "./common/config.js";
 export { LoggerBase, CompositeLogger, type LogPayload, type LoggerType, type LogLevel } from "./common/logger.js";
 export { StreamableHttpRunner } from "./transports/streamableHttp.js";
-export { type CreateConnectionManagerFn } from "./transports/base.js";
+export { type ConnectionManagerFactoryFn } from "./transports/base.js";
 export {
     ConnectionManager,
     type AnyConnectionState,

src/transports/base.ts

@@ -10,18 +10,18 @@ import { ExportsManager } from "../common/exportsManager.js";
 import type { ConnectionManager } from "../common/connectionManager.js";
 import { DeviceId } from "../helpers/deviceId.js";
 
-export type CreateConnectionManagerFn = (createParams: {
+export type ConnectionManagerFactoryFn = (createParams: {
     logger: CompositeLogger;
     deviceId: DeviceId;
-}) => ConnectionManager | Promise<ConnectionManager>;
+}) => Promise<ConnectionManager>;
 
 export abstract class TransportRunnerBase {
     public logger: LoggerBase;
     public deviceId: DeviceId;
 
     protected constructor(
         protected readonly userConfig: UserConfig,
-        private readonly createConnectionManager: CreateConnectionManagerFn,
+        private readonly createConnectionManager: ConnectionManagerFactoryFn,
         additionalLoggers: LoggerBase[]
     ) {
         const loggers: LoggerBase[] = [...additionalLoggers];

src/transports/stdio.ts

@@ -4,7 +4,7 @@ import { JSONRPCMessageSchema } from "@modelcontextprotocol/sdk/types.js";
 import { StdioServerTransport } from "@modelcontextprotocol/sdk/server/stdio.js";
 import { type LoggerBase, LogId } from "../common/logger.js";
 import type { Server } from "../server.js";
-import { type CreateConnectionManagerFn, TransportRunnerBase } from "./base.js";
+import { type ConnectionManagerFactoryFn, TransportRunnerBase } from "./base.js";
 import { type UserConfig } from "../common/config.js";
 
 // This is almost a copy of ReadBuffer from @modelcontextprotocol/sdk
@@ -56,7 +56,7 @@ export class StdioRunner extends TransportRunnerBase {
 
     constructor(
         userConfig: UserConfig,
-        createConnectionManager: CreateConnectionManagerFn,
+        createConnectionManager: ConnectionManagerFactoryFn,
         additionalLoggers: LoggerBase[] = []
     ) {
         super(userConfig, createConnectionManager, additionalLoggers);

src/transports/streamableHttp.ts

@@ -6,7 +6,7 @@ import { isInitializeRequest } from "@modelcontextprotocol/sdk/types.js";
 import { LogId, type LoggerBase } from "../common/logger.js";
 import { type UserConfig } from "../common/config.js";
 import { SessionStore } from "../common/sessionStore.js";
-import { type CreateConnectionManagerFn, TransportRunnerBase } from "./base.js";
+import { type ConnectionManagerFactoryFn, TransportRunnerBase } from "./base.js";
 
 const JSON_RPC_ERROR_CODE_PROCESSING_REQUEST_FAILED = -32000;
 const JSON_RPC_ERROR_CODE_SESSION_ID_REQUIRED = -32001;
@@ -20,7 +20,7 @@ export class StreamableHttpRunner extends TransportRunnerBase {
 
     constructor(
         userConfig: UserConfig,
-        createConnectionManager: CreateConnectionManagerFn,
+        createConnectionManager: ConnectionManagerFactoryFn,
         additionalLoggers: LoggerBase[] = []
     ) {
         super(userConfig, createConnectionManager, additionalLoggers);