Skip to content

Commit 35b4a12

Browse files
chore: rename connectionManager to mcpConnectionManager
1 parent fb4ca48 commit 35b4a12

File tree

10 files changed

+41
-35
lines changed

10 files changed

+41
-35
lines changed

src/common/connectionManager.ts renamed to src/common/mcpConnectionManager.ts

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -63,15 +63,15 @@ export type AnyConnectionState =
6363
| ConnectionStateDisconnected
6464
| ConnectionStateErrored;
6565

66-
export interface ConnectionManagerEvents {
66+
export interface MCPConnectionManagerEvents {
6767
"connection-requested": [AnyConnectionState];
6868
"connection-succeeded": [ConnectionStateConnected];
6969
"connection-timed-out": [ConnectionStateErrored];
7070
"connection-closed": [ConnectionStateDisconnected];
7171
"connection-errored": [ConnectionStateErrored];
7272
}
7373

74-
export class ConnectionManager extends EventEmitter<ConnectionManagerEvents> {
74+
export class MCPConnectionManager extends EventEmitter<MCPConnectionManagerEvents> {
7575
private state: AnyConnectionState;
7676
private deviceId: DeviceId;
7777
private clientName: string;
@@ -158,7 +158,10 @@ export class ConnectionManager extends EventEmitter<ConnectionManagerEvents> {
158158
}
159159

160160
try {
161-
const connectionType = ConnectionManager.inferConnectionTypeFromSettings(this.userConfig, connectionInfo);
161+
const connectionType = MCPConnectionManager.inferConnectionTypeFromSettings(
162+
this.userConfig,
163+
connectionInfo
164+
);
162165
if (connectionType.startsWith("oidc")) {
163166
void this.pingAndForget(serviceProvider);
164167

@@ -212,7 +215,7 @@ export class ConnectionManager extends EventEmitter<ConnectionManagerEvents> {
212215
return this.state;
213216
}
214217

215-
changeState<Event extends keyof ConnectionManagerEvents, State extends ConnectionManagerEvents[Event][0]>(
218+
changeState<Event extends keyof MCPConnectionManagerEvents, State extends MCPConnectionManagerEvents[Event][0]>(
216219
event: Event,
217220
newState: State
218221
): State {

src/common/session.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -7,10 +7,10 @@ import { LogId } from "./logger.js";
77
import EventEmitter from "events";
88
import type {
99
AtlasClusterConnectionInfo,
10-
ConnectionManager,
10+
MCPConnectionManager,
1111
ConnectionSettings,
1212
ConnectionStateConnected,
13-
} from "./connectionManager.js";
13+
} from "./mcpConnectionManager.js";
1414
import type { NodeDriverServiceProvider } from "@mongosh/service-provider-node-driver";
1515
import { ErrorCodes, MongoDBError } from "./errors.js";
1616
import type { ExportsManager } from "./exportsManager.js";
@@ -21,7 +21,7 @@ export interface SessionOptions {
2121
apiClientSecret?: string;
2222
logger: CompositeLogger;
2323
exportsManager: ExportsManager;
24-
connectionManager: ConnectionManager;
24+
connectionManager: MCPConnectionManager;
2525
}
2626

2727
export type SessionEvents = {
@@ -34,7 +34,7 @@ export type SessionEvents = {
3434
export class Session extends EventEmitter<SessionEvents> {
3535
readonly sessionId: string = new ObjectId().toString();
3636
readonly exportsManager: ExportsManager;
37-
readonly connectionManager: ConnectionManager;
37+
readonly connectionManager: MCPConnectionManager;
3838
readonly apiClient: ApiClient;
3939
mcpClient?: {
4040
name?: string;

src/tools/atlas/connect/connectCluster.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ import { generateSecurePassword } from "../../../helpers/generatePassword.js";
66
import { LogId } from "../../../common/logger.js";
77
import { inspectCluster } from "../../../common/atlas/cluster.js";
88
import { ensureCurrentIpInAccessList } from "../../../common/atlas/accessListUtils.js";
9-
import type { AtlasClusterConnectionInfo } from "../../../common/connectionManager.js";
9+
import type { AtlasClusterConnectionInfo } from "../../../common/mcpConnectionManager.js";
1010
import { getDefaultRoleFromConfig } from "../../../common/atlas/roles.js";
1111

1212
const EXPIRY_MS = 1000 * 60 * 60 * 12; // 12 hours

src/transports/base.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ import { McpServer } from "@modelcontextprotocol/sdk/server/mcp.js";
77
import type { LoggerBase } from "../common/logger.js";
88
import { CompositeLogger, ConsoleLogger, DiskLogger, McpLogger } from "../common/logger.js";
99
import { ExportsManager } from "../common/exportsManager.js";
10-
import { ConnectionManager } from "../common/connectionManager.js";
10+
import { MCPConnectionManager } from "../common/mcpConnectionManager.js";
1111
import { DeviceId } from "../helpers/deviceId.js";
1212

1313
export abstract class TransportRunnerBase {
@@ -51,7 +51,7 @@ export abstract class TransportRunnerBase {
5151

5252
const logger = new CompositeLogger(...loggers);
5353
const exportsManager = ExportsManager.init(this.userConfig, logger);
54-
const connectionManager = new ConnectionManager(this.userConfig, this.driverOptions, logger, this.deviceId);
54+
const connectionManager = new MCPConnectionManager(this.userConfig, this.driverOptions, logger, this.deviceId);
5555

5656
const session = new Session({
5757
apiBaseUrl: this.userConfig.apiBaseUrl,

tests/integration/common/connectionManager.oidc.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ import process from "process";
55
import type { MongoDBIntegrationTestCase } from "../tools/mongodb/mongodbHelpers.js";
66
import { describeWithMongoDB, isCommunityServer, getServerVersion } from "../tools/mongodb/mongodbHelpers.js";
77
import { defaultTestConfig, responseAsText, timeout, waitUntil } from "../helpers.js";
8-
import type { ConnectionStateConnected, ConnectionStateConnecting } from "../../../src/common/connectionManager.js";
8+
import type { ConnectionStateConnected, ConnectionStateConnecting } from "../../../src/common/mcpConnectionManager.js";
99
import type { UserConfig } from "../../../src/common/config.js";
1010
import { setupDriverConfig } from "../../../src/common/config.js";
1111
import path from "path";

tests/integration/common/connectionManager.test.ts

Lines changed: 16 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,15 @@
11
import type {
2-
ConnectionManagerEvents,
2+
MCPConnectionManagerEvents,
33
ConnectionStateConnected,
44
ConnectionStringAuthType,
5-
} from "../../../src/common/connectionManager.js";
6-
import { ConnectionManager } from "../../../src/common/connectionManager.js";
5+
} from "../../../src/common/mcpConnectionManager.js";
6+
import { MCPConnectionManager } from "../../../src/common/mcpConnectionManager.js";
77
import type { UserConfig } from "../../../src/common/config.js";
88
import { describeWithMongoDB } from "../tools/mongodb/mongodbHelpers.js";
99
import { describe, beforeEach, expect, it, vi, afterEach } from "vitest";
1010

1111
describeWithMongoDB("Connection Manager", (integration) => {
12-
function connectionManager(): ConnectionManager {
12+
function connectionManager(): MCPConnectionManager {
1313
return integration.mcpServer().session.connectionManager;
1414
}
1515

@@ -24,11 +24,11 @@ describeWithMongoDB("Connection Manager", (integration) => {
2424

2525
describe("when successfully connected", () => {
2626
type ConnectionManagerSpies = {
27-
"connection-requested": (event: ConnectionManagerEvents["connection-requested"][0]) => void;
28-
"connection-succeeded": (event: ConnectionManagerEvents["connection-succeeded"][0]) => void;
29-
"connection-timed-out": (event: ConnectionManagerEvents["connection-timed-out"][0]) => void;
30-
"connection-closed": (event: ConnectionManagerEvents["connection-closed"][0]) => void;
31-
"connection-errored": (event: ConnectionManagerEvents["connection-errored"][0]) => void;
27+
"connection-requested": (event: MCPConnectionManagerEvents["connection-requested"][0]) => void;
28+
"connection-succeeded": (event: MCPConnectionManagerEvents["connection-succeeded"][0]) => void;
29+
"connection-timed-out": (event: MCPConnectionManagerEvents["connection-timed-out"][0]) => void;
30+
"connection-closed": (event: MCPConnectionManagerEvents["connection-closed"][0]) => void;
31+
"connection-errored": (event: MCPConnectionManagerEvents["connection-errored"][0]) => void;
3232
};
3333

3434
let connectionManagerSpies: ConnectionManagerSpies;
@@ -43,7 +43,7 @@ describeWithMongoDB("Connection Manager", (integration) => {
4343
};
4444

4545
for (const [event, spy] of Object.entries(connectionManagerSpies)) {
46-
connectionManager().on(event as keyof ConnectionManagerEvents, spy);
46+
connectionManager().on(event as keyof MCPConnectionManagerEvents, spy);
4747
}
4848

4949
await connectionManager().connect({
@@ -182,9 +182,12 @@ describe("Connection Manager connection type inference", () => {
182182

183183
for (const { userConfig, connectionString, connectionType } of testCases) {
184184
it(`infers ${connectionType} from ${connectionString}`, () => {
185-
const actualConnectionType = ConnectionManager.inferConnectionTypeFromSettings(userConfig as UserConfig, {
186-
connectionString,
187-
});
185+
const actualConnectionType = MCPConnectionManager.inferConnectionTypeFromSettings(
186+
userConfig as UserConfig,
187+
{
188+
connectionString,
189+
}
190+
);
188191

189192
expect(actualConnectionType).toBe(connectionType);
190193
});

tests/integration/helpers.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,8 @@ import type { UserConfig, DriverOptions } from "../../src/common/config.js";
1010
import { McpError, ResourceUpdatedNotificationSchema } from "@modelcontextprotocol/sdk/types.js";
1111
import { config, driverOptions } from "../../src/common/config.js";
1212
import { afterAll, afterEach, beforeAll, describe, expect, it, vi } from "vitest";
13-
import type { ConnectionState } from "../../src/common/connectionManager.js";
14-
import { ConnectionManager } from "../../src/common/connectionManager.js";
13+
import type { ConnectionState } from "../../src/common/mcpConnectionManager.js";
14+
import { MCPConnectionManager } from "../../src/common/mcpConnectionManager.js";
1515
import { DeviceId } from "../../src/helpers/deviceId.js";
1616

1717
interface ParameterInfo {
@@ -72,7 +72,7 @@ export function setupIntegrationTest(
7272
const exportsManager = ExportsManager.init(userConfig, logger);
7373

7474
deviceId = DeviceId.create(logger);
75-
const connectionManager = new ConnectionManager(userConfig, driverOptions, logger, deviceId);
75+
const connectionManager = new MCPConnectionManager(userConfig, driverOptions, logger, deviceId);
7676

7777
const session = new Session({
7878
apiBaseUrl: userConfig.apiBaseUrl,
@@ -315,7 +315,7 @@ export function responseAsText(response: Awaited<ReturnType<Client["callTool"]>>
315315

316316
export function waitUntil<T extends ConnectionState>(
317317
tag: T["tag"],
318-
cm: ConnectionManager,
318+
cm: MCPConnectionManager,
319319
signal: AbortSignal,
320320
additionalCondition?: (state: T) => boolean
321321
): Promise<T> {

tests/integration/telemetry.test.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ import { config, driverOptions } from "../../src/common/config.js";
44
import { DeviceId } from "../../src/helpers/deviceId.js";
55
import { describe, expect, it } from "vitest";
66
import { CompositeLogger } from "../../src/common/logger.js";
7-
import { ConnectionManager } from "../../src/common/connectionManager.js";
7+
import { MCPConnectionManager } from "../../src/common/mcpConnectionManager.js";
88
import { ExportsManager } from "../../src/common/exportsManager.js";
99

1010
describe("Telemetry", () => {
@@ -19,7 +19,7 @@ describe("Telemetry", () => {
1919
apiBaseUrl: "",
2020
logger,
2121
exportsManager: ExportsManager.init(config, logger),
22-
connectionManager: new ConnectionManager(config, driverOptions, logger, deviceId),
22+
connectionManager: new MCPConnectionManager(config, driverOptions, logger, deviceId),
2323
}),
2424
config,
2525
deviceId

tests/unit/common/session.test.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ import { NodeDriverServiceProvider } from "@mongosh/service-provider-node-driver
44
import { Session } from "../../../src/common/session.js";
55
import { config, driverOptions } from "../../../src/common/config.js";
66
import { CompositeLogger } from "../../../src/common/logger.js";
7-
import { ConnectionManager } from "../../../src/common/connectionManager.js";
7+
import { MCPConnectionManager } from "../../../src/common/mcpConnectionManager.js";
88
import { ExportsManager } from "../../../src/common/exportsManager.js";
99
import { DeviceId } from "../../../src/helpers/deviceId.js";
1010

@@ -27,7 +27,7 @@ describe("Session", () => {
2727
apiBaseUrl: "https://api.test.com",
2828
logger,
2929
exportsManager: ExportsManager.init(config, logger),
30-
connectionManager: new ConnectionManager(config, driverOptions, logger, mockDeviceId),
30+
connectionManager: new MCPConnectionManager(config, driverOptions, logger, mockDeviceId),
3131
});
3232

3333
MockNodeDriverServiceProvider.connect = vi.fn().mockResolvedValue({} as unknown as NodeDriverServiceProvider);

tests/unit/resources/common/debug.test.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ import { Session } from "../../../../src/common/session.js";
44
import { Telemetry } from "../../../../src/telemetry/telemetry.js";
55
import { config, driverOptions } from "../../../../src/common/config.js";
66
import { CompositeLogger } from "../../../../src/common/logger.js";
7-
import { ConnectionManager } from "../../../../src/common/connectionManager.js";
7+
import { MCPConnectionManager } from "../../../../src/common/mcpConnectionManager.js";
88
import { ExportsManager } from "../../../../src/common/exportsManager.js";
99
import { DeviceId } from "../../../../src/helpers/deviceId.js";
1010

@@ -15,7 +15,7 @@ describe("debug resource", () => {
1515
apiBaseUrl: "",
1616
logger,
1717
exportsManager: ExportsManager.init(config, logger),
18-
connectionManager: new ConnectionManager(config, driverOptions, logger, deviceId),
18+
connectionManager: new MCPConnectionManager(config, driverOptions, logger, deviceId),
1919
});
2020
const telemetry = Telemetry.create(session, { ...config, telemetry: "disabled" }, deviceId);
2121

0 commit comments

Comments
 (0)