chore: remove configFile and state.json

Author: fmenezes

README.md

@@ -157,8 +157,6 @@ The MongoDB MCP Server can be configured using multiple methods, with the follow
 
 1. Command-line arguments
 2. Environment variables
-3. Configuration file
-4. Default values
 
 ### Configuration Options
 
@@ -167,6 +165,12 @@ The MongoDB MCP Server can be configured using multiple methods, with the follow
 | `apiClientId`      | Atlas API client ID for authentication                                                                                |
 | `apiClientSecret`  | Atlas API client secret for authentication                                                                            |
 | `connectionString` | MongoDB connection string for direct database connections (optional users may choose to inform it on every tool call) |
+| `logPath`          | Folder to store logs                                                                                                  |
+
+**Default Log Path:**
+
+- Windows: `%LOCALAPPDATA%\mongodb\mongodb-mcp\.app-logs`
+- macOS/Linux: `~/.mongodb/mongodb-mcp/.app-logs`
 
 ### Atlas API Access
 
@@ -195,23 +199,6 @@ To use the Atlas API tools, you'll need to create a service account in MongoDB A
 
 ### Configuration Methods
 
-#### Configuration File
-
-Create a JSON configuration file at one of these locations:
-
-- Linux/macOS: `/etc/mongodb-mcp.conf`
-- Windows: `%LOCALAPPDATA%\mongodb\mongodb-mcp\mongodb-mcp.conf`
-
-Example configuration file:
-
-```json
-{
-  "apiClientId": "your-atlas-client-id",
-  "apiClientSecret": "your-atlas-client-secret",
-  "connectionString": "mongodb+srv://username:[email protected]/myDatabase"
-}
-```
-
 #### Environment Variables
 
 Set environment variables with the prefix `MDB_MCP_` followed by the option name in uppercase with underscores:
@@ -223,14 +210,16 @@ export MDB_MCP_API_CLIENT_SECRET="your-atlas-client-secret"
 
 # Set a custom MongoDB connection string
 export MDB_MCP_CONNECTION_STRING="mongodb+srv://username:[email protected]/myDatabase"
+
+export MDB_MCP_LOG_PATH="/path/to/logs"
 ```
 
 #### Command-Line Arguments
 
 Pass configuration options as command-line arguments when starting the server:
 
 ```shell
-node dist/index.js --apiClientId="your-atlas-client-id" --apiClientSecret="your-atlas-client-secret" --connectionString="mongodb+srv://username:[email protected]/myDatabase"
+node dist/index.js --apiClientId="your-atlas-client-id" --apiClientSecret="your-atlas-client-secret" --connectionString="mongodb+srv://username:[email protected]/myDatabase" --logPath=/path/to/logs
 ```
 
 ## 🤝 Contributing

src/config.ts

@@ -5,15 +5,15 @@ import argv from "yargs-parser";
 import packageJson from "../package.json" with { type: "json" };
 import fs from "fs";
 import { ReadConcernLevel, ReadPreferenceMode, W } from "mongodb";
-const { localDataPath, configPath } = getLocalDataPath();
+import { log } from "console";
 
 // If we decide to support non-string config options, we'll need to extend the mechanism for parsing
 // env variables.
 interface UserConfig {
     apiBaseUrl: string;
     apiClientId?: string;
     apiClientSecret?: string;
-    stateFile: string;
+    logPath: string;
     connectionString?: string;
     connectOptions: {
         readConcern: ReadConcernLevel;
@@ -25,7 +25,7 @@ interface UserConfig {
 
 const defaults: UserConfig = {
     apiBaseUrl: "https://cloud.mongodb.com/",
-    stateFile: path.join(localDataPath, "state.json"),
+    logPath: getLogPath(),
     connectOptions: {
         readConcern: "local",
         readPreference: "secondaryPreferred",
@@ -36,7 +36,6 @@ const defaults: UserConfig = {
 
 const mergedUserConfig = {
     ...defaults,
-    ...getFileConfig(),
     ...getEnvConfig(),
     ...getCliConfig(),
 };
@@ -46,33 +45,28 @@ const config = {
     atlasApiVersion: `2025-03-12`,
     version: packageJson.version,
     userAgent: `AtlasMCP/${packageJson.version} (${process.platform}; ${process.arch}; ${process.env.HOSTNAME || "unknown"})`,
-    localDataPath,
 };
 
 export default config;
 
-function getLocalDataPath(): { localDataPath: string; configPath: string } {
+function getLogPath(): string {
     let localDataPath: string | undefined;
-    let configPath: string | undefined;
 
     if (process.platform === "win32") {
         const appData = process.env.APPDATA;
         const localAppData = process.env.LOCALAPPDATA ?? process.env.APPDATA;
         if (localAppData && appData) {
             localDataPath = path.join(localAppData, "mongodb", "mongodb-mcp");
-            configPath = path.join(localDataPath, "mongodb-mcp.conf");
         }
     }
 
     localDataPath ??= path.join(os.homedir(), ".mongodb", "mongodb-mcp");
-    configPath ??= "/etc/mongodb-mcp.conf";
 
-    fs.mkdirSync(localDataPath, { recursive: true });
+    const logPath = path.join(localDataPath, ".app-logs");
 
-    return {
-        localDataPath,
-        configPath,
-    };
+    fs.mkdirSync(logPath, { recursive: true });
+
+    return logPath;
 }
 
 // Gets the config supplied by the user as environment variables. The variable names
@@ -125,17 +119,6 @@ function SNAKE_CASE_toCamelCase(str: string): string {
     return str.toLowerCase().replace(/([-_][a-z])/g, (group) => group.toUpperCase().replace("_", ""));
 }
 
-// Gets the config supplied by the user as a JSON file. The file is expected to be located in the local data path
-// and named `config.json`.
-function getFileConfig(): Partial<UserConfig> {
-    try {
-        const config = fs.readFileSync(configPath, "utf8");
-        return JSON.parse(config);
-    } catch {
-        return {};
-    }
-}
-
 // Reads the cli args and parses them into a UserConfig object.
 function getCliConfig() {
     return argv(process.argv.slice(2)) as unknown as Partial<UserConfig>;

src/logger.ts

@@ -100,11 +100,8 @@ const logger = new ProxyingLogger();
 export default logger;
 
 export async function initializeLogger(server: McpServer): Promise<void> {
-    const logDir = path.join(config.localDataPath, ".app-logs");
-    await fs.mkdir(logDir, { recursive: true });
-
     const manager = new MongoLogManager({
-        directory: path.join(config.localDataPath, ".app-logs"),
+        directory: config.logPath,
         retentionDays: 30,
         onwarn: console.warn,
         onerror: console.error,

src/server.ts

@@ -11,14 +11,14 @@ import { mongoLogId } from "mongodb-log-writer";
 export class Server {
     state: State = defaultState;
     apiClient?: ApiClient;
-    initialized: boolean = false;
 
-    private async init() {
-        if (this.initialized) {
-            return;
-        }
+    private createMcpServer(): McpServer {
+        const server = new McpServer({
+            name: "MongoDB Atlas",
+            version: config.version,
+        });
 
-        await this.state.loadCredentials();
+        server.server.registerCapabilities({ logging: {} });
 
         if (config.apiClientId && config.apiClientSecret) {
             this.apiClient = new ApiClient({
@@ -29,25 +29,13 @@ export class Server {
             });
         }
 
-        this.initialized = true;
-    }
-
-    private createMcpServer(): McpServer {
-        const server = new McpServer({
-            name: "MongoDB Atlas",
-            version: config.version,
-        });
-
-        server.server.registerCapabilities({ logging: {} });
-
         registerAtlasTools(server, this.state, this.apiClient);
         registerMongoDBTools(server, this.state);
 
         return server;
     }
 
     async connect(transport: Transport) {
-        await this.init();
         const server = this.createMcpServer();
         await server.connect(transport);
         await initializeLogger(server);

src/state.ts

@@ -1,34 +1,8 @@
 import { NodeDriverServiceProvider } from "@mongosh/service-provider-node-driver";
-import { AsyncEntry } from "@napi-rs/keyring";
-import logger from "./logger.js";
-import { mongoLogId } from "mongodb-log-writer";
-
-interface Credentials {
-    connectionString?: string;
-}
 
 export class State {
-    private entry = new AsyncEntry("mongodb-mcp", "credentials");
-    credentials: Credentials = {};
     serviceProvider?: NodeDriverServiceProvider;
-
-    public async persistCredentials(): Promise<void> {
-        await this.entry.setPassword(JSON.stringify(this.credentials));
-    }
-
-    public async loadCredentials(): Promise<boolean> {
-        try {
-            const data = await this.entry.getPassword();
-            if (data) {
-                this.credentials = JSON.parse(data);
-            }
-
-            return true;
-        } catch (err: unknown) {
-            logger.error(mongoLogId(1_000_007), "state", `Failed to load state: ${err}`);
-            return false;
-        }
-    }
+    connectionString?: string;
 }
 
 const defaultState = new State();

src/tools/atlas/atlasTool.ts

@@ -10,7 +10,7 @@ export abstract class AtlasToolBase extends ToolBase {
         super(state);
     }
 
-    protected ensureAuthenticated(): void {
+    protected ensureAuthenticated(): asserts this is { apiClient: ApiClient } {
         if (!this.apiClient) {
             throw new Error(
                 "Not authenticated make sure to configure MCP server with MDB_MCP_API_CLIENT_ID and MDB_MCP_API_CLIENT_SECRET environment variables."

src/tools/atlas/createAccessList.ts

@@ -39,7 +39,7 @@ export class CreateAccessListTool extends AtlasToolBase {
         }));
 
         if (currentIpAddress) {
-            const currentIp = await this.apiClient!.getIpInfo();
+            const currentIp = await this.apiClient.getIpInfo();
             const input = {
                 groupId: projectId,
                 ipAddress: currentIp.currentIpv4Address,
@@ -56,7 +56,7 @@ export class CreateAccessListTool extends AtlasToolBase {
 
         const inputs = [...ipInputs, ...cidrInputs];
 
-        await this.apiClient!.createProjectIpAccessList({
+        await this.apiClient.createProjectIpAccessList({
             params: {
                 path: {
                     groupId: projectId,

src/tools/atlas/createDBUser.ts

@@ -53,7 +53,7 @@ export class CreateDBUserTool extends AtlasToolBase {
                 : undefined,
         } as CloudDatabaseUser;
 
-        await this.apiClient!.createDatabaseUser({
+        await this.apiClient.createDatabaseUser({
             params: {
                 path: {
                     groupId: projectId,

src/tools/atlas/createFreeCluster.ts

@@ -38,7 +38,7 @@ export class CreateFreeClusterTool extends AtlasToolBase {
             terminationProtectionEnabled: false,
         } as unknown as ClusterDescription20240805;
 
-        await this.apiClient!.createCluster({
+        await this.apiClient.createCluster({
             params: {
                 path: {
                     groupId: projectId,

src/tools/atlas/inspectAccessList.ts

@@ -13,7 +13,7 @@ export class InspectAccessListTool extends AtlasToolBase {
     protected async execute({ projectId }: ToolArgs<typeof this.argsShape>): Promise<CallToolResult> {
         this.ensureAuthenticated();
 
-        const accessList = await this.apiClient!.listProjectIpAccessLists({
+        const accessList = await this.apiClient.listProjectIpAccessLists({
             params: {
                 path: {
                     groupId: projectId,