address comments

Author: blva

src/common/atlas/accessListUtils.ts

@@ -2,10 +2,12 @@ import { ApiClient } from "./apiClient.js";
 import logger, { LogId } from "../logger.js";
 import { ApiClientError } from "./apiClientError.js";
 
+export const DEFAULT_ACCESS_LIST_COMMENT = "Added by MongoDB MCP Server to enable tool access";
+
 export async function makeCurrentIpAccessListEntry(
     apiClient: ApiClient,
     projectId: string,
-    comment: string = "Added by Atlas MCP"
+    comment: string = DEFAULT_ACCESS_LIST_COMMENT
 ) {
     const { currentIpv4Address } = await apiClient.getIpInfo();
     return {
@@ -23,7 +25,7 @@ export async function makeCurrentIpAccessListEntry(
  */
 export async function ensureCurrentIpInAccessList(apiClient: ApiClient, projectId: string): Promise<void> {
     // Get the current public IP
-    const entry = await makeCurrentIpAccessListEntry(apiClient, projectId, "Added by MCP pre-run access list helper");
+    const entry = await makeCurrentIpAccessListEntry(apiClient, projectId, DEFAULT_ACCESS_LIST_COMMENT);
     try {
         await apiClient.createProjectIpAccessList({
             params: { path: { groupId: projectId } },
@@ -36,7 +38,12 @@ export async function ensureCurrentIpInAccessList(apiClient: ApiClient, projectI
         );
     } catch (err) {
         if (err instanceof ApiClientError && err.response?.status === 409) {
-            // 409 Conflict: entry already exists, ignore
+            // 409 Conflict: entry already exists, log info
+            logger.debug(
+                LogId.atlasIpAccessListAdded,
+                "accessListUtils",
+                `IP address ${entry.ipAddress} is already present in the access list for project ${projectId}.`
+            );
             return;
         }
         logger.debug(

src/tools/atlas/create/createAccessList.ts

@@ -2,9 +2,7 @@ import { z } from "zod";
 import { CallToolResult } from "@modelcontextprotocol/sdk/types.js";
 import { AtlasToolBase } from "../atlasTool.js";
 import { ToolArgs, OperationType } from "../../tool.js";
-import { makeCurrentIpAccessListEntry } from "../../../common/atlas/accessListUtils.js";
-
-const DEFAULT_COMMENT = "Added by Atlas MCP";
+import { makeCurrentIpAccessListEntry, DEFAULT_ACCESS_LIST_COMMENT } from "../../../common/atlas/accessListUtils.js";
 
 export class CreateAccessListTool extends AtlasToolBase {
     public name = "atlas-create-access-list";
@@ -18,7 +16,11 @@ export class CreateAccessListTool extends AtlasToolBase {
             .optional(),
         cidrBlocks: z.array(z.string().cidr()).describe("CIDR blocks to allow access from").optional(),
         currentIpAddress: z.boolean().describe("Add the current IP address").default(false),
-        comment: z.string().describe("Comment for the access list entries").default(DEFAULT_COMMENT).optional(),
+        comment: z
+            .string()
+            .describe("Comment for the access list entries")
+            .default(DEFAULT_ACCESS_LIST_COMMENT)
+            .optional(),
     };
 
     protected async execute({
@@ -35,22 +37,22 @@ export class CreateAccessListTool extends AtlasToolBase {
         const ipInputs = (ipAddresses || []).map((ipAddress) => ({
             groupId: projectId,
             ipAddress,
-            comment: comment || DEFAULT_COMMENT,
+            comment: comment || DEFAULT_ACCESS_LIST_COMMENT,
         }));
 
         if (currentIpAddress) {
             const input = await makeCurrentIpAccessListEntry(
                 this.session.apiClient,
                 projectId,
-                comment || DEFAULT_COMMENT
+                comment || DEFAULT_ACCESS_LIST_COMMENT
             );
             ipInputs.push(input);
         }
 
         const cidrInputs = (cidrBlocks || []).map((cidrBlock) => ({
             groupId: projectId,
             cidrBlock,
-            comment: comment || DEFAULT_COMMENT,
+            comment: comment || DEFAULT_ACCESS_LIST_COMMENT,
         }));
 
         const inputs = [...ipInputs, ...cidrInputs];

tests/unit/accessListUtils.test.ts

@@ -1,6 +1,6 @@
 import { describe, it, expect, vi } from "vitest";
 import { ApiClient } from "../../src/common/atlas/apiClient.js";
-import { ensureCurrentIpInAccessList } from "../../src/common/atlas/accessListUtils.js";
+import { ensureCurrentIpInAccessList, DEFAULT_ACCESS_LIST_COMMENT } from "../../src/common/atlas/accessListUtils.js";
 import { ApiClientError } from "../../src/common/atlas/apiClientError.js";
 
 describe("accessListUtils", () => {
@@ -13,9 +13,7 @@ describe("accessListUtils", () => {
         // eslint-disable-next-line @typescript-eslint/unbound-method
         expect(apiClient.createProjectIpAccessList).toHaveBeenCalledWith({
             params: { path: { groupId: "projectId" } },
-            body: [
-                { groupId: "projectId", ipAddress: "127.0.0.1", comment: "Added by MCP pre-run access list helper" },
-            ],
+            body: [{ groupId: "projectId", ipAddress: "127.0.0.1", comment: DEFAULT_ACCESS_LIST_COMMENT }],
         });
     });
 
@@ -35,9 +33,7 @@ describe("accessListUtils", () => {
         // eslint-disable-next-line @typescript-eslint/unbound-method
         expect(apiClient.createProjectIpAccessList).toHaveBeenCalledWith({
             params: { path: { groupId: "projectId" } },
-            body: [
-                { groupId: "projectId", ipAddress: "127.0.0.1", comment: "Added by MCP pre-run access list helper" },
-            ],
+            body: [{ groupId: "projectId", ipAddress: "127.0.0.1", comment: DEFAULT_ACCESS_LIST_COMMENT }],
         });
     });
 });