fix: address comments

Author: fmenezes

src/config.ts

@@ -49,21 +49,11 @@ const config = {
 export default config;
 
 function getLogPath(): string {
-    let localDataPath: string | undefined;
+    const localDataPath = (process.platform === "win32") ?
+        path.join(process.env.LOCALAPPDATA || process.env.APPDATA || os.homedir(), "mongodb")
+        : path.join(os.homedir(), ".mongodb");
 
-    if (process.platform === "win32") {
-        const appData = process.env.APPDATA;
-        const localAppData = process.env.LOCALAPPDATA ?? process.env.APPDATA;
-        if (localAppData && appData) {
-            localDataPath = path.join(localAppData, "mongodb", "mongodb-mcp");
-        }
-    }
-
-    localDataPath ??= path.join(os.homedir(), ".mongodb", "mongodb-mcp");
-
-    const logPath = path.join(localDataPath, ".app-logs");
-
-    fs.mkdirSync(logPath, { recursive: true });
+    const logPath = path.join(localDataPath, "mongodb-mcp", ".app-logs");
 
     return logPath;
 }

src/logger.ts

@@ -1,3 +1,4 @@
+import fs from "fs";
 import { MongoLogId, MongoLogManager, MongoLogWriter } from "mongodb-log-writer";
 import config from "./config.js";
 import redact from "mongodb-redact";
@@ -97,7 +98,21 @@ class ProxyingLogger extends LoggerBase {
 const logger = new ProxyingLogger();
 export default logger;
 
+async function mkdirPromise(path: fs.PathLike, options?: fs.Mode | fs.MakeDirectoryOptions) {
+    return new Promise<string | undefined>((resolve, reject) => {
+        fs.mkdir(path, options, (err, resultPath) => {
+            if (err) {
+                reject(err);
+            } else {
+                resolve(resultPath);
+            }
+        });
+    });
+}
+
 export async function initializeLogger(server: McpServer): Promise<void> {
+    await mkdirPromise(config.logPath, { recursive: true });
+
     const manager = new MongoLogManager({
         directory: config.logPath,
         retentionDays: 30,

src/state.ts

@@ -2,7 +2,6 @@ import { NodeDriverServiceProvider } from "@mongosh/service-provider-node-driver
 
 export class State {
     serviceProvider?: NodeDriverServiceProvider;
-    connectionString?: string;
 }
 
 const defaultState = new State();

src/tools/mongodb/connect.ts

@@ -20,7 +20,7 @@ export class ConnectTool extends MongoDBToolBase {
     protected async execute({
         connectionStringOrClusterName,
     }: ToolArgs<typeof this.argsShape>): Promise<CallToolResult> {
-        connectionStringOrClusterName ??= config.connectionString || this.state.connectionString;
+        connectionStringOrClusterName ??= config.connectionString;
         if (!connectionStringOrClusterName) {
             return {
                 content: [

src/tools/mongodb/mongodbTool.ts

@@ -66,6 +66,5 @@ export abstract class MongoDBToolBase extends ToolBase {
         });
 
         state.serviceProvider = provider;
-        state.connectionString = connectionString;
     }
 }